fix(j-s): update info section components

[thorhildurt]

Asana task

What

• Fixing a tiny bug introduced here
• We were using component that was rendering the case number when user was typing it, which is not expected behaviour

Why

• Not expected behaviour

Screenshots / Gifs

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features
  • Introduced a new component for displaying prosecutor and defendant entries in the court case view
• Refactor
  • Replaced the existing court case information component with a more focused prosecutor and defendant entries component

[coderabbitai]

Walkthrough

The pull request modifies the ReceptionAndAssignment.tsx component in the judicial system web application. The primary change involves replacing the existing CourtCaseInfo component with a new ProsecutorAndDefendantsEntries component. This replacement suggests a shift in how case information is displayed, focusing more on prosecutor and defendant details within the court reception and assignment workflow. The change maintains the existing case context by passing the same workingCase prop to the new component.

Changes

File	Change Summary
apps/judicial-system/web/src/routes/Court/components/ReceptionAndAssignment/ReceptionAndAssignment.tsx	Replaced CourtCaseInfo with ProsecutorAndDefendantsEntries component, wrapped in a <Box> element

Possibly related PRs

• feat(j-s): Set court session type to arraignment when subpoena created #17209: Modifies court session type to "arraignment" when creating a subpoena
• fix(j-s): Add case info also to reception and assignment component #17360: Adds case information to the reception and assignment component
• fix(j-s): Add missing court case number to info card #17348: Enhances InfoCard component with court case number

Suggested labels

automerge

Suggested reviewers

• unakb
• oddsson

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 90a1af8 and 2c11f2e.

📒 Files selected for processing (1)

• apps/judicial-system/web/src/routes/Court/components/ReceptionAndAssignment/ReceptionAndAssignment.tsx (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

apps/judicial-system/web/src/routes/Court/components/ReceptionAndAssignment/ReceptionAndAssignment.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

🔇 Additional comments (3)

apps/judicial-system/web/src/routes/Court/components/ReceptionAndAssignment/ReceptionAndAssignment.tsx (3)

22-22: LGTM! Import statement follows best practices.

The import statement follows NextJS best practices and maintains type safety through proper path resolution.

---

117-119: Verify the component replacement's impact on user experience.

While the implementation looks correct, we should verify that this change addresses the reported issue of case number rendering during typing.

Consider implementing debounce or throttle if the new component still needs to handle real-time updates, to prevent unnecessary re-renders during typing.

---

117-119: Verify alignment with PR objectives.

The replacement of CourtCaseInfo with ProsecutorAndDefendantsEntries aligns with the PR objective to fix the case number rendering behavior. However, we should ensure that:

1. The new component doesn't reintroduce similar real-time update issues
2. The user experience remains consistent with expectations

✅ Verification successful

Replacement component properly fixes the rendering issue

The replacement of CourtCaseInfo with ProsecutorAndDefendantsEntries successfully addresses the case number rendering behavior because:

• The new component doesn't handle or display the court case number at all
• It only renders static prosecutor and defendant information
• No real-time update mechanisms are present that could cause unexpected rendering

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the implementation details of both components to ensure the fix

# Check the old implementation
rg -A 10 "CourtCaseInfo.*=.*{" 

# Check the new implementation
ast-grep --pattern 'const ProsecutorAndDefendantsEntries = $_'

Length of output: 199

---

Script:

#!/bin/bash
# Search for CourtCaseInfo component definition and usage
rg "CourtCaseInfo" -A 5

# Search for ProsecutorAndDefendantsEntries component
rg "ProsecutorAndDefendantsEntries" -A 5

# Look for any real-time update patterns in both components
rg -g "*.{ts,tsx}" "(onChange|onInput|watch)" -A 3

Length of output: 119145

---

Script:

#!/bin/bash
# Search for ProsecutorAndDefendantsEntries implementation
ast-grep --pattern 'export const ProsecutorAndDefendantsEntries = $$$'

# Search for any real-time update related code in CaseInfo.tsx
rg -g "CaseInfo.tsx" "(onChange|onInput|watch|useEffect)" -A 5

Length of output: 135

---

Script:

#!/bin/bash
# Try to find the component implementation directly
rg -A 20 "ProsecutorAndDefendantsEntries" apps/judicial-system/web/src/components/CaseInfo/CaseInfo.tsx

# Look for the file content
cat apps/judicial-system/web/src/components/CaseInfo/CaseInfo.tsx

Length of output: 4904

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[datadog-island-is]

Datadog Report

All test runs 448b0d7 🔗

✅ 10 Total Test Services: 0 Failed, 10 Passed
➡️ Test Sessions change in coverage: 95 no change

Test Services

This report shows up to 10 services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
air-discount-scheme-web	0	0	0	2	0	6.8s	1 no change	Link
api	0	0	0	4	0	2.45s	1 no change	Link
application-api-files	0	0	0	2	0	4.31s	1 no change	Link
application-core	0	0	0	97	0	15.24s	1 no change	Link
application-system-api	0	0	0	46	0	2m 11.84s	1 no change	Link
application-template-api-modules	0	0	0	118	0	2m 6.71s	1 no change	Link
application-templates-accident-notification	0	0	0	140	0	13.43s	1 no change	Link
application-templates-criminal-record	0	0	0	2	0	9.95s	1 no change	Link
application-templates-driving-license	0	0	0	13	0	12.72s	1 no change	Link
application-templates-example-payment	0	0	0	2	0	10.01s	1 no change	Link

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.60%. Comparing base (464dcc4) to head (5d8f756).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #17515   +/-   ##
=======================================
  Coverage   35.60%   35.60%           
=======================================
  Files        7015     7015           
  Lines      150385   150382    -3     
  Branches    43007    43007           
=======================================
+ Hits        53541    53544    +3     
+ Misses      96844    96838    -6     

Flag	Coverage Δ
air-discount-scheme-web	0.00% <ø> (ø)
api	3.33% <ø> (ø)
application-api-files	62.06% <ø> (ø)
application-core	75.66% <ø> (ø)
application-system-api	38.71% <ø> (-0.01%)	⬇️
application-template-api-modules	27.56% <ø> (-0.01%)	⬇️
application-templates-accident-notification	27.60% <ø> (ø)
application-templates-car-recycling	3.12% <ø> (ø)
application-templates-criminal-record	25.79% <ø> (ø)
application-templates-driving-license	18.15% <ø> (ø)
application-templates-estate	13.57% <ø> (ø)
application-templates-example-payment	24.66% <ø> (ø)
application-templates-financial-aid	14.47% <ø> (ø)
application-templates-general-petition	23.13% <ø> (ø)
application-templates-inheritance-report	6.59% <ø> (ø)
application-templates-marriage-conditions	14.84% <ø> (ø)
application-templates-mortgage-certificate	43.73% <ø> (ø)
application-templates-new-primary-school	21.02% <ø> (ø)
application-templates-parental-leave	29.92% <ø> (ø)
application-types	6.47% <ø> (ø)
application-ui-components	1.17% <ø> (ø)
application-ui-shell	22.09% <ø> (ø)
clients-charge-fjs-v2	28.88% <ø> (ø)
judicial-system-web	27.85% <ø> (ø)
web	2.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../ReceptionAndAssignment/ReceptionAndAssignment.tsx	0.00% <ø> (ø)

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 464dcc4...5d8f756. Read the comment docs.