feat(rental-agreement): Update fireProtection and otherCost input validations

[hebaulf]

Update fireProtection and otherCost input validations

https://app.asana.com/0/1208271027457465/1208557871739584/f - In comments

What

• Add validation for empty or incorrect values for necessary inputs in otherCosts section
• Add validation for empty or incorrect values for necessary inputs in fireProtection section

Why

Should not be able to continue to next step if inputs are empty or values incorrect for necessary information.

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

• main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.61%. Comparing base (54ee764) to head (f55df00).
Report is 1 commits behind head on rental-agreement-application.

Additional details and impacted files

@@                       Coverage Diff                        @@
##           rental-agreement-application   #17519      +/-   ##
================================================================
- Coverage                         35.65%   35.61%   -0.04%     
================================================================
  Files                              7006     7015       +9     
  Lines                            149965   150300     +335     
  Branches                          42997    43111     +114     
================================================================
+ Hits                              53465    53533      +68     
- Misses                            96500    96767     +267     

Flag	Coverage Δ
api	3.33% <ø> (ø)
application-system-api	38.72% <ø> (-0.01%)	⬇️
application-ui-shell	22.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 50 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ee764...f55df00. Read the comment docs.

[datadog-island-is]

Datadog Report

All test runs caa0861 🔗

✅ 3 Total Test Services: 0 Failed, 3 Passed
➡️ Test Sessions change in coverage: 6 no change

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
api	0	0	0	4	0	2.45s	1 no change	Link
application-system-api	0	0	0	46	0	2m 16.67s	1 no change	Link
application-ui-shell	0	0	0	74	0	31.11s	1 no change	Link