refactor(island-ui): filter count + mobile drawer #17570

disaerna · 2025-01-20T12:48:48Z

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Formatting passes locally with my changes
I have rebased against main before asking for a review

coderabbitai · 2025-01-20T12:48:56Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-01-21T15:06:20Z

Deployed services: application-system-api,application-system-form,service-portal,portals-admin,consultation-portal,api,web,skilavottord-web,island-ui-storybook,air-discount-scheme-web,application-system-api-worker,services-bff-portals-admin,services-bff-portals-my-pages.
Excluded services: contentful-apps

datadog-island-is · 2025-01-21T15:11:59Z

Datadog Report

All test runs 2cbcf34 🔗

✅ 10 Total Test Services: 0 Failed, 10 Passed
🔻 Test Sessions change in coverage: 9 decreased, 1 increased (+0.38%), 189 no change

Test Services

This report shows up to 10 services

Service Name	Passed	Total Time	Code Coverage Change	Test Service View
`air-discount-scheme-backend`	63	32.14s	N/A	Link
`air-discount-scheme-web`	2	8.17s	N/A	Link
`api`	4	6.23s	N/A	Link
`api-catalogue-services`	23	11.22s	N/A	Link
`api-domains-air-discount-scheme`	6	22.13s	N/A	Link
`api-domains-assets`	3	15.69s	N/A	Link
`api-domains-auth-admin`	18	12.89s	N/A	Link
`api-domains-communications`	5	39.78s	N/A	Link
`api-domains-criminal-record`	5	12.14s	N/A	Link
`api-domains-driving-license`	23	49.75s	N/A	Link

🔻 Code Coverage Decreases vs Default Branch (9)

This report shows up to 5 code coverage decreases.

shared-form-fields - jest 41.34% (-0.68%) - Details
shared-components - jest 36.37% (-0.48%) - Details
island-ui-core - jest 30.84% (-0.39%) - Details
portals-core - jest 28.62% (-0.36%) - Details
application-ui-shell - jest 28.52% (-0.18%) - Details

codecov · 2025-01-21T15:25:30Z

Codecov Report

Attention: Patch coverage is 1.58730% with 62 lines in your changes missing coverage. Please review.

Project coverage is 35.56%. Comparing base (27c57ef) to head (e4227bd).

Files with missing lines	Patch %	Lines
libs/island-ui/core/src/lib/Filter/Filter.tsx	0.00%	35 Missing ⚠️
...land-ui/core/src/lib/Filter/FilterMobileDrawer.tsx	3.57%	27 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17570      +/-   ##
==========================================
- Coverage   35.57%   35.56%   -0.02%     
==========================================
  Files        7031     7032       +1     
  Lines      150481   150534      +53     
  Branches    42970    43012      +42     
==========================================
+ Hits        53536    53539       +3     
- Misses      96945    96995      +50

Flag	Coverage Δ
air-discount-scheme-backend	`48.15% <ø> (ø)`
air-discount-scheme-web	`0.00% <ø> (ø)`
api	`3.33% <ø> (ø)`
api-catalogue-services	`75.81% <ø> (ø)`
api-domains-air-discount-scheme	`37.90% <ø> (ø)`
api-domains-assets	`26.71% <ø> (ø)`
api-domains-auth-admin	`48.49% <ø> (ø)`
api-domains-communications	`39.48% <ø> (ø)`
api-domains-criminal-record	`47.81% <ø> (ø)`
api-domains-driving-license	`44.77% <ø> (ø)`
api-domains-education	`31.09% <ø> (ø)`
api-domains-mortgage-certificate	`34.96% <ø> (ø)`
api-domains-payment-schedule	`42.04% <ø> (ø)`
application-api-files	`61.80% <ø> (ø)`
application-core	`75.68% <ø> (ø)`
application-system-api	`38.67% <ø> (-0.01%)`	⬇️
application-template-api-modules	`27.56% <ø> (-0.01%)`	⬇️
application-templates-accident-notification	`27.60% <ø> (ø)`
application-templates-car-recycling	`3.12% <ø> (ø)`
application-templates-criminal-record	`25.79% <ø> (ø)`
application-templates-driving-license	`18.15% <ø> (ø)`
application-templates-estate	`13.50% <1.58%> (-0.09%)`	⬇️
application-templates-example-payment	`24.66% <ø> (ø)`
application-templates-financial-aid	`14.99% <ø> (ø)`
application-templates-general-petition	`23.11% <ø> (ø)`
application-templates-inheritance-report	`6.59% <ø> (ø)`
application-templates-marriage-conditions	`14.80% <ø> (ø)`
application-templates-mortgage-certificate	`43.73% <ø> (ø)`
application-templates-new-primary-school	`21.02% <ø> (ø)`
application-templates-parental-leave	`29.92% <ø> (ø)`
application-types	`6.47% <ø> (ø)`
application-ui-components	`1.17% <ø> (ø)`
application-ui-shell	`21.87% <1.58%> (-0.13%)`	⬇️
auth-admin-web	`2.43% <ø> (ø)`
auth-nest-tools	`31.69% <ø> (ø)`
auth-shared	`75.00% <ø> (ø)`
clients-driving-license	`40.68% <ø> (ø)`
clients-driving-license-book	`43.75% <ø> (ø)`
clients-financial-statements-inao	`49.48% <ø> (ø)`
clients-license-client	`1.26% <ø> (ø)`
clients-middlewares	`73.39% <ø> (+0.65%)`	⬆️
clients-regulations	`42.75% <ø> (ø)`
clients-rsk-company-registry	`31.18% <ø> (ø)`
clients-rsk-personal-tax-return	`38.32% <ø> (ø)`
clients-syslumenn	`49.18% <ø> (ø)`
clients-zendesk	`49.88% <ø> (ø)`
cms	`0.39% <ø> (ø)`
cms-translations	`38.81% <ø> (ø)`
content-search-index-manager	`95.65% <ø> (ø)`
content-search-toolkit	`8.16% <ø> (ø)`
contentful-apps	`4.56% <ø> (ø)`
dokobit-signing	`61.66% <ø> (ø)`
email-service	`59.68% <ø> (ø)`
feature-flags	`90.40% <ø> (ø)`
file-storage	`45.32% <ø> (ø)`
financial-aid-backend	`51.38% <ø> (ø)`
icelandic-names-registry-backend	`54.44% <ø> (ø)`
infra-nest-server	`48.06% <ø> (ø)`
infra-tracing	`69.94% <ø> (ø)`
island-ui-core	`29.99% <0.00%> (-0.33%)`	⬇️
judicial-system-api	`20.07% <ø> (ø)`
judicial-system-audit-trail	`68.53% <ø> (ø)`
judicial-system-backend	`55.81% <ø> (ø)`
judicial-system-formatters	`78.86% <ø> (ø)`
judicial-system-scheduler	`71.24% <ø> (ø)`
judicial-system-types	`37.77% <ø> (ø)`
judicial-system-web	`27.88% <1.58%> (-0.10%)`	⬇️
license-api	`42.91% <ø> (-0.08%)`	⬇️
localization	`10.15% <ø> (ø)`
logging	`58.02% <ø> (ø)`
message-queue	`67.76% <ø> (ø)`
nest-audit	`65.78% <ø> (ø)`
nest-aws	`51.93% <ø> (ø)`
nest-config	`76.05% <ø> (ø)`
nest-core	`53.16% <ø> (ø)`
nest-swagger	`51.13% <ø> (ø)`
nova-sms	`60.96% <ø> (ø)`
portals-admin-regulations-admin	`1.80% <ø> (ø)`
portals-core	`19.39% <1.58%> (-0.21%)`	⬇️
regulations	`16.78% <ø> (ø)`
residence-history	`85.00% <ø> (ø)`
services-auth-admin-api	`52.47% <ø> (+<0.01%)`	⬆️
services-auth-delegation-api	`58.47% <ø> (ø)`
services-auth-ids-api	`52.52% <ø> (+0.01%)`	⬆️
services-auth-public-api	`49.36% <ø> (ø)`
services-sessions	`65.33% <ø> (ø)`
services-university-gateway	`49.46% <ø> (-0.03%)`	⬇️
services-user-notification	`46.52% <ø> (ø)`
services-user-profile	`56.85% <ø> (ø)`
shared-components	`29.14% <1.58%> (-0.34%)`	⬇️
shared-form-fields	`32.92% <1.58%> (-0.45%)`	⬇️
shared-mocking	`58.64% <ø> (ø)`
shared-pii	`92.85% <ø> (ø)`
shared-problem	`87.50% <ø> (ø)`
shared-utils	`28.67% <ø> (ø)`
skilavottord-ws	`23.97% <ø> (ø)`
web	`2.39% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...land-ui/core/src/lib/Filter/FilterMobileDrawer.tsx	`3.57% <3.57%> (ø)`
libs/island-ui/core/src/lib/Filter/Filter.tsx	`3.84% <0.00%> (-3.57%)`	⬇️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27c57ef...e4227bd. Read the comment docs.

disaerna added 6 commits January 15, 2025 11:07

WIP filter

5ff4634

Merge branch 'main' into my-pages/replace-filter

28fe627

fix button inline styles

879a7a5

revert

8553ae2

Merge branch 'my-pages/replace-filter' into refactor/ui-core/filter

15e1915

feat: count number + mobile logic WIP

a588050

disaerna added the deploy-feature Deploys features to dev label Jan 20, 2025

disaerna added 2 commits January 21, 2025 10:18

Merge branch 'main' into refactor/ui-core/filter

d9df66d

fix: mobile filter layout

c7dfd09

feat: add touchevents

abdecbc

disaerna removed the deploy-feature Deploys features to dev label Jan 22, 2025

Merge branch 'main' into refactor/ui-core/filter

70e62d9

disaerna added the deploy-feature Deploys features to dev label Jan 22, 2025

Merge branch 'main' into refactor/ui-core/filter

e4227bd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(island-ui): filter count + mobile drawer #17570

refactor(island-ui): filter count + mobile drawer #17570

disaerna commented Jan 20, 2025

coderabbitai bot commented Jan 20, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

github-actions bot commented Jan 21, 2025

datadog-island-is bot commented Jan 21, 2025 •

edited

Loading

codecov bot commented Jan 21, 2025 •

edited

Loading

refactor(island-ui): filter count + mobile drawer #17570

Are you sure you want to change the base?

refactor(island-ui): filter count + mobile drawer #17570

Conversation

disaerna commented Jan 20, 2025

...

What

Why

Screenshots / Gifs

Checklist:

coderabbitai bot commented Jan 20, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

github-actions bot commented Jan 21, 2025

datadog-island-is bot commented Jan 21, 2025 • edited Loading

Datadog Report

🔻 Code Coverage Decreases vs Default Branch (9)

codecov bot commented Jan 21, 2025 • edited Loading

Codecov Report

datadog-island-is bot commented Jan 21, 2025 •

edited

Loading

codecov bot commented Jan 21, 2025 •

edited

Loading