fix(secondary school): Update message IDs

[johannaagma]

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• Bug Fixes
  • Corrected message identifiers in secondary school application templates.
  • Updated specific message IDs to more accurately reflect their purpose.
  • Improved message identification for different application states and user groups.

The changes ensure more precise message labeling across various sections of the application, enhancing clarity and reducing potential confusion in message routing and display.

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between b18b8fe and 6dd9e69.

📒 Files selected for processing (41)

• apps/contentful-apps/components/Layout.tsx (1 hunks)
• apps/contentful-apps/components/LocalhostWarning.tsx (1 hunks)
• apps/contentful-apps/components/MideindTranslationSidebar/fieldUtils/index.tsx (1 hunks)
• apps/contentful-apps/pages/fields/active-translations-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/admin-only-json-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/admin-only-short-text-checkbox-list-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/admin-only-short-text-dropdown-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/admin-only-short-text-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/admin-only-single-reference-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/article-related-articles-field.tsx (2 hunks)
• apps/contentful-apps/pages/fields/article-subarticles-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/content-type-notifications-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/embed-link-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/form-default-namespace-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/formatted-location-input-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/publish-date-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/theme-properties-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/time-duration-field.tsx (1 hunks)
• apps/contentful-apps/pages/fields/vacancy-contacts-field.tsx (1 hunks)
• apps/financial-aid/backend/src/app/modules/staff/test/numberOfUsersForMunicipality.spec.ts (1 hunks)
• apps/skilavottord/web/screens/Overview/components/ActionCard/ActionCard.tsx (1 hunks)
• apps/skilavottord/ws/src/app/modules/samgongustofa/samgongustofa.service.ts (8 hunks)
• apps/tools/contentful-role-permissions/utils/index.ts (1 hunks)
• apps/web/screens/PetitionView/PetitionView.tsx (1 hunks)
• libs/api/domains/auth-admin/src/lib/client/clients.service.spec.ts (8 hunks)
• libs/api/domains/directorate-of-labour/src/lib/parentalLeavePregnancyStatus.model.ts (1 hunks)
• libs/api/domains/disability-license/src/lib/disability-license.resolver.ts (1 hunks)
• libs/api/domains/driving-license/src/lib/graphql/qualityPhoto.resolver.ts (1 hunks)
• libs/api/domains/driving-license/src/lib/graphql/qualitySignature.resolver.ts (1 hunks)
• libs/application/templates/financial-aid/src/fields/TaxReturnFilesForm/taxFormContent.tsx (1 hunks)
• libs/application/templates/financial-aid/src/lib/hooks/useFileUpload.ts (1 hunks)
• libs/infra-express-server/src/lib/infra-express-server.ts (3 hunks)
• libs/infra-nest-server/src/lib/httpRequestDurationMiddleware.ts (1 hunks)
• libs/island-ui/contentful/src/lib/IframeModal/IframeModal.tsx (1 hunks)
• libs/island-ui/core/src/lib/DatePicker/DatePicker.stories.tsx (2 hunks)
• libs/island-ui/core/src/lib/ModalBase/ModalBase.tsx (1 hunks)
• libs/island-ui/core/src/lib/VisuallyHidden/VisuallyHidden.tsx (1 hunks)
• libs/portals/admin/ids-admin/src/hooks/useDynamicShadow.tsx (1 hunks)
• libs/portals/admin/ids-admin/src/screens/Client/EditClient.tsx (1 hunks)
• libs/portals/shared-modules/delegations/src/hooks/useDynamicShadow.tsx (1 hunks)
• libs/shared/types/src/lib/shorthash.d.ts (1 hunks)

 ________________________________________________________________________________________________________________________________________
< Use assertions to prevent the impossible. Assertions validate your assumptions. Use them to protect your code from an uncertain world. >
 ----------------------------------------------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

Walkthrough

This pull request involves precise updates to message identifiers across multiple files in the secondary school application templates. The changes focus on correcting and refining message IDs to improve specificity and accuracy. Modifications were made in three key message files: application.ts, conclusion.ts, and error.ts, each addressing a specific identifier discrepancy to ensure more precise message referencing.

Changes

File	Change Summary
libs/application/templates/secondary-school/src/lib/messages/application.ts	Updated actionCardInReview message ID from ss.application:actionCardCompleted to ss.application:actionCardInReview
libs/application/templates/secondary-school/src/lib/messages/conclusion.ts	Updated message IDs for alertMessageFreshman and alertMessageGeneral to ss.application:conclusion.overview.alertMessageFreshman and ss.application:conclusion.overview.alertMessageGeneral, respectively
libs/application/templates/secondary-school/src/lib/messages/error.ts	Corrected errorValidateCanCreateDescription message ID from ss.application:error.errorValidateCanCreateTitle to ss.application:error.errorValidateCanCreateDescription

Possibly related PRs

• fix(parliamentary): minor text updates and cleanup #15815: The change in message identifiers in the main PR is related to the updates made in the messages.ts file of the parliamentary section, as both involve modifications to message identifiers for clarity and specificity.
• fix(portals-admin): tweaks lks vs þí #16484: The changes in the main PR regarding message identifiers are similar to the updates in the Constituency component, where message identifiers are also modified to enhance clarity and user experience.
• fix(old-age-pension): Change banner to warning and add link to income plan in pendingAction #16485: The main PR's focus on updating message identifiers aligns with the changes made to the OldAgePensionTemplate, where message identifiers are also updated for better clarity in user communication.

Suggested labels

automerge

Suggested reviewers

• johannaagma

Tip

You can generate walkthrough in a markdown collapsible section to save space.

Enable the reviews.collapse_walkthrough setting in your project's settings in CodeRabbit to generate walkthrough in a markdown collapsible section.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

libs/application/templates/secondary-school/src/lib/messages/application.ts (1)

33-36: Update the description comment to match the state

The description comment still refers to "completed" state while the message is for "in review" state.

    id: 'ss.application:actionCardInReview',
    defaultMessage: 'Í vinnslu hjá stofnun',
    description:
-      'Description of application state/status when application is completed',
+      'Description of application state/status when application is in review',

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bb52c30 and 7a83e08.

📒 Files selected for processing (3)

• libs/application/templates/secondary-school/src/lib/messages/application.ts (1 hunks)
• libs/application/templates/secondary-school/src/lib/messages/conclusion.ts (1 hunks)
• libs/application/templates/secondary-school/src/lib/messages/error.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

libs/application/templates/secondary-school/src/lib/messages/application.ts (1)

Pattern libs/**/*: "Confirm that the code adheres to the following:

• Reusability of components and hooks across different NextJS apps.
• TypeScript usage for defining props and exporting types.
• Effective tree-shaking and bundling practices."

libs/application/templates/secondary-school/src/lib/messages/error.ts (1)

Pattern libs/**/*: "Confirm that the code adheres to the following:

• Reusability of components and hooks across different NextJS apps.
• TypeScript usage for defining props and exporting types.
• Effective tree-shaking and bundling practices."

libs/application/templates/secondary-school/src/lib/messages/conclusion.ts (1)

Pattern libs/**/*: "Confirm that the code adheres to the following:

• Reusability of components and hooks across different NextJS apps.
• TypeScript usage for defining props and exporting types.
• Effective tree-shaking and bundling practices."

🔇 Additional comments (3)

libs/application/templates/secondary-school/src/lib/messages/error.ts (1)

15-15: LGTM! Message ID now correctly reflects its content type

The message ID has been appropriately updated to use 'Description' instead of 'Title', which accurately represents its purpose as an error description message.

libs/application/templates/secondary-school/src/lib/messages/application.ts (1)

33-33: LGTM! Message ID now correctly reflects the application state

The message ID has been appropriately updated to use 'actionCardInReview' instead of 'actionCardCompleted', which accurately represents the "in review" state.

libs/application/templates/secondary-school/src/lib/messages/conclusion.ts (1)

68-68: LGTM! Message IDs now clearly differentiate between user groups

The message IDs have been appropriately updated to distinguish between freshman and general alert messages, improving code clarity and maintainability.

Also applies to: 74-74

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.57%. Comparing base (91ed8b9) to head (b18b8fe).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17608      +/-   ##
==========================================
- Coverage   35.57%   35.57%   -0.01%     
==========================================
  Files        7030     7030              
  Lines      150489   150495       +6     
  Branches    42973    42979       +6     
==========================================
- Hits        53536    53535       -1     
- Misses      96953    96960       +7     

Flag	Coverage Δ
application-system-api	38.67% <ø> (-0.01%)	⬇️
services-auth-delegation-api	58.39% <ø> (-0.09%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...uth-admin-web/components/Admin/nav/AdminTabNav.tsx	0.00% <ø> (ø)
...h-admin-web/components/Client/nav/ClientTabNav.tsx	0.00% <ø> (ø)
...s/secondary-school/src/lib/messages/application.ts	100.00% <ø> (ø)
...es/secondary-school/src/lib/messages/conclusion.ts	100.00% <ø> (ø)
...mplates/secondary-school/src/lib/messages/error.ts	100.00% <ø> (ø)

... and 134 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91ed8b9...b18b8fe. Read the comment docs.

[datadog-island-is]

Datadog Report

All test runs 29abe4e 🔗

✅ 5 Total Test Services: 0 Failed, 4 Passed
➡️ Test Sessions change in coverage: 11 no change

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
api	0	0	0	4	0	13.73s	1 no change	Link
auth-admin-web	0	0	0	1	0	41.38s	1 no change	Link
judicial-system-backend	0	0	0	7351	0	0s	N/A	Link
services-auth-delegation-api	0	0	0	99	0	0s	N/A	Link
services-auth-personal-representative	0	0	0	0	0	526.89ms	1 no change	Link

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

apps/auth-admin-web/components/Admin/nav/AdminTabNav.tsx (1)

Line range hint 1-150: Consider NextJS best practices improvements.

While the component functions correctly, there are several opportunities for improvement:

1. Consider using Next.js's built-in Link component for tab navigation if these tabs correspond to different routes
2. The localization initialization could be moved outside the component to prevent unnecessary state recreation
3. The repetitive button structure could be extracted into a reusable component

Would you like me to provide a refactored version implementing these improvements?

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a83e08 and b18b8fe.

📒 Files selected for processing (2)

• apps/auth-admin-web/components/Admin/nav/AdminTabNav.tsx (1 hunks)
• apps/auth-admin-web/components/Client/nav/ClientTabNav.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• apps/auth-admin-web/components/Client/nav/ClientTabNav.tsx

🧰 Additional context used

📓 Path-based instructions (1)

apps/auth-admin-web/components/Admin/nav/AdminTabNav.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

[coderabbitai]

🛠️ Refactor suggestion

Follow React/TypeScript naming conventions for props.

The prop renaming from activeTab to activetab breaks the camelCase naming convention commonly used in React and TypeScript. This inconsistency could lead to confusion and maintenance issues.

Apply this diff to maintain consistent naming:

 const AdminTabNav: React.FC<React.PropsWithChildren<Props>> = ({
   handleTabChange,
-  activeTab: activetab,
+  activeTab,
   children,
 }) => {

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	handleTabChange,
	activeTab: activetab,
	children,
	handleTabChange,
	activeTab,
	children,