Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved language menu to top nav #15565

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

milinddethe15
Copy link
Contributor

@milinddethe15 milinddethe15 commented Aug 15, 2024

Description

Moved language menu to top navigation bar for easily switch between languages
Preview link: https://deploy-preview-15565--preliminary-istio.netlify.app/

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

Signed-off-by: milinddethe15 <[email protected]>
@milinddethe15 milinddethe15 requested a review from a team as a code owner August 15, 2024 13:14
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Aug 15, 2024
@istio-testing
Copy link
Contributor

Hi @milinddethe15. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@craigbox
Copy link
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Aug 15, 2024
@craigbox
Copy link
Contributor

Thanks for the contribution! I'm not 100% sure it's something we want to go with. My initial thoughts:

  • we have limited the number of things in this header for width:
Screenshot 2024-08-16 at 10 50 03 AM
  • the header "English" doesn't immediately suggest to me this is a language drop down

  • I might ask our zh-cn audience if they think this is useful first?

@milinddethe15
Copy link
Contributor Author

Hi @craigbox

  • the header "English" doesn't immediately suggest to me this is a language drop down

I have changed language menu title to en/关于, much clearer

  • I might ask our zh-cn audience if they think this is useful first?

#11554 is open for this.
let me know once it’s finalized

  • we have limited the number of things in this header for width

maybe a seperate dropdown, outside the main navigation bar, can be created.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Dec 7, 2024
@craigbox
Copy link
Contributor

Hey @milinddethe15, could you (a) introduce UK (b) use the "language" icon SVG from https://clarity.design/documentation/icons/shapes ?

@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Dec 27, 2024
@craigbox
Copy link
Contributor

merging master brought UK language in also - now just to change the icon (and remove dropdown indicator) please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user experience ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants