-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved language menu to top nav #15565
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: milinddethe15 <[email protected]>
Hi @milinddethe15. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Signed-off-by: milinddethe15 <[email protected]>
Hi @craigbox
I have changed language menu title to
#11554 is open for this.
maybe a seperate dropdown, outside the main navigation bar, can be created. |
Hey @milinddethe15, could you (a) introduce UK (b) use the "language" icon SVG from https://clarity.design/documentation/icons/shapes ? |
merging master brought UK language in also - now just to change the icon (and remove dropdown indicator) please! |
Description
Moved language menu to top navigation bar for easily switch between languages
Preview link: https://deploy-preview-15565--preliminary-istio.netlify.app/
Reviewers