Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentaions for mirror and mirrorPercentage #16137

Closed
wants to merge 1 commit into from

Conversation

windsonsea
Copy link
Member

Fix #16134

Added - before two list items

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@windsonsea windsonsea requested a review from a team as a code owner December 30, 2024 03:44
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 30, 2024
@istio-testing
Copy link
Contributor

@windsonsea: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
doc.test.profile-default_istio.io 184e663 link true /test doc.test.profile-default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@craigbox
Copy link
Contributor

It's correct without, it's a field on the route: https://istio.io/latest/docs/reference/config/networking/virtual-service/#HTTPRoute

The problem is the rendering in the tabset gadget page, and that starts at #15689.

@windsonsea
Copy link
Member Author

ok, seems this can be closed.

@windsonsea windsonsea closed this Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indentation on Mirror content is wrong
4 participants