Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/doc #60

Merged
merged 60 commits into from
Jul 12, 2021
Merged

Feat/doc #60

merged 60 commits into from
Jul 12, 2021

Conversation

charnysh-dev
Copy link
Contributor

No description provided.

@shcheklein shcheklein temporarily deployed to cml-dev-feat-doc-qwa63zxdwjkfw June 4, 2021 17:33 Inactive
@julieg18 julieg18 temporarily deployed to cml-dev-feat-doc-kwke0z44muxo5 June 4, 2021 17:49 Inactive
@julieg18
Copy link
Contributor

julieg18 commented Jun 4, 2021

Looks like your pull request has a package-lock.json, causing the build to break. Deleting it and using yarn-lock.json should stop the build from breaking.
image

@charnysh-dev
Copy link
Contributor Author

Looks like your pull request has a package-lock.json, causing the build to break. Deleting it and using yarn-lock.json should stop the build from breaking.
image

I'm refactoring codebase now, the next commit will not include one of them. thank you

@shcheklein shcheklein temporarily deployed to cml-dev-feat-doc-hzdqku1kic7vu June 8, 2021 21:00 Inactive
@shcheklein
Copy link
Member

@charnysh-dev it is still failing to deploy

-----> Building on the Heroku-18 stack
-----> Using buildpack: heroku/nodejs
-----> Node.js app detected
-----> Build failed
 !     Two different lockfiles found: package-lock.json and yarn.lock
       Both npm and yarn have created lockfiles for this application,
       but only one can be used to install dependencies. Installing
       dependencies using the wrong package manager can result in missing
       packages or subtle bugs in production.
       - To use npm to install your application's dependencies please delete
         the yarn.lock file.
         $ git rm yarn.lock
       - To use yarn to install your application's dependences please delete
         the package-lock.json file.
         $ git rm package-lock.json
    
       https://help.heroku.com/0KU2EM53
 !     Push rejected, failed to compile Node.js app.
 !     Push failed

@shcheklein shcheklein temporarily deployed to cml-dev-feat-doc-8pctedhbd5khv June 9, 2021 02:08 Inactive
@shcheklein
Copy link
Member

@charnysh-dev could you clarify please - what is the reason to remove yarn? the intention here is to stay as close as possible for now to the original dvc.org stack.

Also it is still failing:

-----> Building on the Heroku-18 stack -----> Using buildpack: heroku/nodejs -----> Node.js app detected

-----> Creating runtime environment

   NPM_CONFIG_LOGLEVEL=error
   NODE_ENV=production
   NODE_MODULES_CACHE=true
   NODE_VERBOSE=false

-----> Installing binaries
engines.node (package.json): <=15.x
engines.npm (package.json): unspecified (use default)

   Resolving node version <=15.x...
   Downloading and installing node 15.14.0...
   Using default npm version: 7.7.6

-----> Installing dependencies
Installing node modules

   added 2986 packages, and audited 2987 packages in 3m
   
   229 packages are looking for funding
     run `npm fund` for details
   
   134 vulnerabilities (10 low, 70 moderate, 52 high, 2 critical)
   
   To address issues that do not require attention, run:
     npm audit fix
   
   To address all issues possible (including breaking changes), run:
     npm audit fix --force
   
   Some issues need review, and may require choosing
   a different dependency.
   
   Run `npm audit` for details.

-----> Build
Detected both "build" and "heroku-postbuild" scripts
Running heroku-postbuild

   > [email protected] heroku-postbuild
   > ./scripts/deploy-with-s3.js
   
   {
     AWS_REGION: undefined,
     HEROKU_APP_NAME: 'cml-dev-feat-doc-8pctedhbd5khv',
     s3Bucket: undefined,
     s3Prefix: 'dvc-org-pulls/cml-dev-feat-doc-8pctedhbd5khv',
     hasCreds: false
   }

The current prefix "dvc-org-pulls/cml-dev-feat-doc-8pctedhbd5khv" is empty! Attempting to fall back on production cache.
Downloading "public" from s3://undefined/dvc-org-prod/
Downloading ".cache" from s3://undefined/dvc-org-prod-cache/
Error downloading initial data MissingRequiredParameter: Missing required key 'Bucket' in params
at ParamValidator.fail (/tmp/build_53a9896d/node_modules/aws-sdk/lib/param_validator.js:50:37)
at ParamValidator.validateStructure (/tmp/build_53a9896d/node_modules/aws-sdk/lib/param_validator.js:61:14)
at ParamValidator.validateMember (/tmp/build_53a9896d/node_modules/aws-sdk/lib/param_validator.js:88:21)
at ParamValidator.validate (/tmp/build_53a9896d/node_modules/aws-sdk/lib/param_validator.js:34:10)
at Request.VALIDATE_PARAMETERS (/tmp/build_53a9896d/node_modules/aws-sdk/lib/event_listeners.js:126:42)
at Request.callListeners (/tmp/build_53a9896d/node_modules/aws-sdk/lib/sequential_executor.js:106:20)
at callNextListener (/tmp/build_53a9896d/node_modules/aws-sdk/lib/sequential_executor.js:96:12)
at /tmp/build_53a9896d/node_modules/aws-sdk/lib/event_listeners.js:86:9
at finish (/tmp/build_53a9896d/node_modules/aws-sdk/lib/config.js:386:7)
at /tmp/build_53a9896d/node_modules/aws-sdk/lib/config.js:428:9 {
code: 'MissingRequiredParameter',
time: 2021-06-09T02:11:14.301Z
}
Error downloading initial data MissingRequiredParameter: Missing required key 'Bucket' in params
at ParamValidator.fail (/tmp/build_53a9896d/node_modules/aws-sdk/lib/param_validator.js:50:37)
at ParamValidator.validateStructure (/tmp/build_53a9896d/node_modules/aws-sdk/lib/param_validator.js:61:14)
at ParamValidator.validateMember (/tmp/build_53a9896d/node_modules/aws-sdk/lib/param_validator.js:88:21)
at ParamValidator.validate (/tmp/build_53a9896d/node_modules/aws-sdk/lib/param_validator.js:34:10)
at Request.VALIDATE_PARAMETERS (/tmp/build_53a9896d/node_modules/aws-sdk/lib/event_listeners.js:126:42)
at Request.callListeners (/tmp/build_53a9896d/node_modules/aws-sdk/lib/sequential_executor.js:106:20)
at callNextListener (/tmp/build_53a9896d/node_modules/aws-sdk/lib/sequential_executor.js:96:12)
at /tmp/build_53a9896d/node_modules/aws-sdk/lib/event_listeners.js:86:9
at finish (/tmp/build_53a9896d/node_modules/aws-sdk/lib/config.js:386:7)
at /tmp/build_53a9896d/node_modules/aws-sdk/lib/config.js:428:9 {
code: 'MissingRequiredParameter',
time: 2021-06-09T02:11:14.302Z
}
/bin/sh: 1: yarn: not found

The first Gatsby build attempt failed!
Error: Command failed: yarn build
at checkExecSyncError (node:child_process:707:11)
at execSync (node:child_process:744:15)
at run (/tmp/build_53a9896d/scripts/deploy-with-s3.js:77:3)
at main (/tmp/build_53a9896d/scripts/deploy-with-s3.js:101:7)
at processTicksAndRejections (node:internal/process/task_queues:94:5) {
status: 127,
signal: null,
output: [ null, null, null ],
pid: 13215,
stdout: null,
stderr: null
}
Retrying with a cleared cache:
/bin/sh: 1: yarn: not found
Error: Command failed: yarn build
at checkExecSyncError (node:child_process:707:11)
at execSync (node:child_process:744:15)
at run (/tmp/build_53a9896d/scripts/deploy-with-s3.js:77:3)
at main (/tmp/build_53a9896d/scripts/deploy-with-s3.js:114:7) {
status: 127,
signal: null,
output: [ null, null, null ],
pid: 13216,
stdout: null,
stderr: null
}
-----> Build failed

   We're sorry this build is failing! You can troubleshoot common issues here:
   https://devcenter.heroku.com/articles/troubleshooting-node-deploys
   
   If you're stuck, please submit a ticket so we can help:
   https://help.heroku.com/
   
   Love,
   Heroku

! Push rejected, failed to compile Node.js app.
! Push failed

Build system depends on AWS S3 cache to speedup things. I think it's fine to disable it for now and get to it later.

@shcheklein shcheklein temporarily deployed to cml-dev-feat-doc-eu2om6fsnjnfr June 9, 2021 03:59 Inactive
@shcheklein
Copy link
Member

shcheklein commented Jun 9, 2021

@charnysh-dev

Screen Shot 2021-06-08 at 9 50 22 PM

@charnysh-dev
Copy link
Contributor Author

@charnysh-dev

Screen Shot 2021-06-08 at 9 50 22 PM

@shcheklein Could you share the heroku error log?

@julieg18
Copy link
Contributor

julieg18 commented Jun 9, 2021

Here's the build log:

-----> Building on the Heroku-18 stack
-----> Using buildpack: heroku/nodejs
-----> Node.js app detected
       
-----> Creating runtime environment
       
       NPM_CONFIG_LOGLEVEL=error
       USE_YARN_CACHE=true
       NODE_ENV=production
       NODE_MODULES_CACHE=true
       NODE_VERBOSE=false
       
-----> Installing binaries
       engines.node (package.json):  <=15.x
       engines.npm (package.json):   unspecified (use default)
       engines.yarn (package.json):  unspecified (use default)
       
       Resolving node version <=15.x...
       Downloading and installing node 15.14.0...
       Using default npm version: 7.7.6
       Resolving yarn version 1.22.x...
       Downloading and installing yarn (1.22.10)
       Installed yarn 1.22.10
       
-----> Installing dependencies
       Installing node modules (yarn.lock)
       yarn install v1.22.10
       [1/4] Resolving packages...
       [2/4] Fetching packages...
       warning [email protected]: Invalid bin field for "url-loader".
       info [email protected]: The platform "linux" is incompatible with this module.
       info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
       info [email protected]: The platform "linux" is incompatible with this module.
       info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
       [3/4] Linking dependencies...
       warning " > [email protected]" has unmet peer dependency "jquery@>=1.8.0".
       [4/4] Building fresh packages...
       Done in 158.70s.
       
-----> Build
       Running build (yarn)
       yarn run v1.22.10
       $ gatsby build
       success open and validate gatsby-configs - 0.308s
lscpu: failed to determine number of CPUs: /sys/devices/system/cpu/possible: No such file or directory
lscpu: failed to determine number of CPUs: /sys/devices/system/cpu/possible: No such file or directory
       success load plugins - 1.575s
       success onPreInit - 0.187s
       success delete html and css files from previous builds - 0.004s
       success initialize cache - 0.008s
       success copy gatsby files - 0.070s
       success onPreBootstrap - 0.023s
lscpu: failed to determine number of CPUs: /sys/devices/system/cpu/possible: No such file or directory
       success createSchemaCustomization - 0.416s
warning The gatsby-transformer-sharp plugin has generated no Gatsby nodes. Do you need it?
       success Checking for changed pages - 0.000s
       success source and transform nodes - 0.194s
       success building schema - 0.791s
       info Total nodes: 93, SitePage nodes: 8 (use --verbose for breakdown)
       success createPages - 0.061s
       success Checking for changed pages - 0.000s
       success createPagesStatefully - 0.125s
       success update schema - 0.052s
       success onPreExtractQueries - 0.001s
       success extract queries from components - 0.942s
       success write out redirect data - 0.001s
       success Build manifest and related icons - 0.196s
       success onPostBootstrap - 0.198s
       info bootstrap finished - 8.698s
       success run static queries - 0.020s - 3/3 150.75/s
       success run page queries - 1.231s - 10/10 8.12/s
       success write out requires - 0.005s
       success Building production JavaScript and CSS bundles - 56.712s
lscpu: failed to determine number of CPUs: /sys/devices/system/cpu/possible: No such file or directory
       success Rewriting compilation hashes - 0.002s
       success Building HTML renderer - 16.464s
       success Building static HTML for pages - 1.612s - 10/10 6.21/s
       success onPostBuild - 0.012s
       info Done building in 85.535365755 sec
       Done in 86.81s.
       
-----> Caching build
       Saving 1 cacheDirectories (package.json):
       - node_modules
       
-----> Pruning devDependencies
       yarn install v1.22.10
       [1/4] Resolving packages...
       [2/4] Fetching packages...
       info [email protected]: The platform "linux" is incompatible with this module.
       info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
       info [email protected]: The platform "linux" is incompatible with this module.
       info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
       [3/4] Linking dependencies...
       warning " > [email protected]" has unmet peer dependency "jquery@>=1.8.0".
       [4/4] Building fresh packages...
       warning Ignored scripts due to flag.
       Done in 16.77s.
       
-----> Build succeeded!
 !     Unmet dependencies don't fail yarn install but may cause runtime issues
       https://github.com/npm/npm/issues/7494
-----> Discovering process types
       Procfile declares types     -> (none)
       Default types for buildpack -> web
-----> Compressing...
       Done: 158M
-----> Launching...
       Released v4
       https://cml-dev-feat-doc-eu2om6fsnjnfr.herokuapp.com/ deployed to Heroku

Application logs:

2021-06-09T11:12:13.062714+00:00 heroku[router]: at=info method=GET path="/page-data/404.html/page-data.json" host=cml-dev-feat-doc-eu2om6fsnjnfr.herokuapp.com request_id=4d715e2a-f85e-4762-8f32-7519f5d3e517 fwd="47.220.230.154" dyno=web.1 connect=0ms service=18ms status=404 bytes=12337 protocol=https
2021-06-09T11:12:13.114846+00:00 heroku[router]: at=info method=GET path="/page-data/sq/d/2744905544.json" host=cml-dev-feat-doc-eu2om6fsnjnfr.herokuapp.com request_id=7f8ea202-071e-408a-b5a6-d48abd786b20 fwd="47.220.230.154" dyno=web.1 connect=6ms service=28ms status=404 bytes=12337 protocol=https
2021-06-09T11:12:13.115985+00:00 heroku[router]: at=info method=GET path="/page-data/sq/d/4024388462.json" host=cml-dev-feat-doc-eu2om6fsnjnfr.herokuapp.com request_id=c9ab5298-aa8a-441d-9656-2b2a4f3315f1 fwd="47.220.230.154" dyno=web.1 connect=4ms service=29ms status=404 bytes=12337 protocol=https
2021-06-09T11:12:13.219834+00:00 heroku[router]: at=info method=GET path="/page-data/app-data.json" host=cml-dev-feat-doc-eu2om6fsnjnfr.herokuapp.com request_id=42fb948e-a9ad-4e18-b500-100ee270e06b fwd="47.220.230.154" dyno=web.1 connect=2ms service=35ms status=404 bytes=12337 protocol=https
2021-06-09T11:12:13.247833+00:00 heroku[router]: at=info method=GET path="/icons/icon-48x48.png?v=bb7958d60b3bf9ae408ff5da2b71ea52" host=cml-dev-feat-doc-eu2om6fsnjnfr.herokuapp.com request_id=9ea6340a-0eda-4c46-ad8e-3d2b1ad835dc fwd="47.220.230.154" dyno=web.1 connect=0ms service=15ms status=404 bytes=12337 protocol=https
2021-06-09T11:12:13.391576+00:00 heroku[router]: at=info method=GET path="/manifest.webmanifest" host=cml-dev-feat-doc-eu2om6fsnjnfr.herokuapp.com request_id=3da8587f-914d-4d60-bacc-0a3c7975f151 fwd="47.220.230.154" dyno=web.1 connect=6ms service=53ms status=404 bytes=12337 protocol=https
2021-06-09T11:12:13.437993+00:00 heroku[router]: at=info method=GET path="/favicon.ico" host=cml-dev-feat-doc-eu2om6fsnjnfr.herokuapp.com request_id=5beb4325-b8b7-43e3-b389-40352bc8b9f0 fwd="47.220.230.154" dyno=web.1 connect=7ms service=67ms status=404 bytes=12337 protocol=https
2021-06-09T11:12:13.595197+00:00 heroku[router]: at=info method=GET path="/favicon-32x32.png" host=cml-dev-feat-doc-eu2om6fsnjnfr.herokuapp.com request_id=fe1531e6-ae13-40f6-be52-f4e5ba1cb8e4 fwd="47.220.230.154" dyno=web.1 connect=2ms service=67ms status=404 bytes=12337 protocol=https
2021-06-09T11:12:13.732193+00:00 heroku[router]: at=info method=GET path="/favicon-16x16.png" host=cml-dev-feat-doc-eu2om6fsnjnfr.herokuapp.com request_id=7f5141df-528b-4334-b350-7a41b0286b16 fwd="47.220.230.154" dyno=web.1 connect=2ms service=42ms status=404 bytes=12337 protocol=https
2021-06-09T11:12:19.735205+00:00 heroku[router]: at=info method=GET path="/manifest.webmanifest" host=cml-dev-feat-doc-eu2om6fsnjnfr.herokuapp.com request_id=6806a3a1-a822-4908-8f82-0a94a44bdd98 fwd="47.220.230.154" dyno=web.1 connect=1ms service=50ms status=404 bytes=12337 protocol=https

@shcheklein shcheklein temporarily deployed to cml-dev-feat-doc-eu2om6fsnjnfr June 10, 2021 02:01 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-feat-doc-eu2om6fsnjnfr June 10, 2021 02:45 Inactive
@julieg18
Copy link
Contributor

If you needed logs for the latest build:
Build logs:

-----> Building on the Heroku-18 stack
-----> Using buildpack: heroku/nodejs
-----> Node.js app detected
       
-----> Creating runtime environment
       
       NPM_CONFIG_LOGLEVEL=error
       USE_YARN_CACHE=true
       NODE_ENV=production
       NODE_MODULES_CACHE=true
       NODE_VERBOSE=false
       
-----> Installing binaries
       engines.node (package.json):  <=15.x
       engines.npm (package.json):   unspecified (use default)
       engines.yarn (package.json):  unspecified (use default)
       
       Resolving node version <=15.x...
       Downloading and installing node 15.14.0...
       Using default npm version: 7.7.6
       Resolving yarn version 1.22.x...
       Downloading and installing yarn (1.22.10)
       Installed yarn 1.22.10
       
-----> Restoring cache
       Loading 1 from cacheDirectories (package.json):
       - node_modules
       
-----> Installing dependencies
       Installing node modules (yarn.lock)
       yarn install v1.22.10
       [1/4] Resolving packages...
       success Already up-to-date.
       Done in 2.10s.
       
-----> Build
       Detected both "build" and "heroku-postbuild" scripts
       Running heroku-postbuild (yarn)
       yarn run v1.22.10
       $ gatsby build
       success open and validate gatsby-configs - 0.258s
lscpu: failed to determine number of CPUs: /sys/devices/system/cpu/possible: No such file or directory
lscpu: failed to determine number of CPUs: /sys/devices/system/cpu/possible: No such file or directory
       success load plugins - 1.382s
       success onPreInit - 0.178s
       success delete html and css files from previous builds - 0.004s
       success initialize cache - 0.009s
       success copy gatsby files - 0.060s
       success onPreBootstrap - 0.015s
lscpu: failed to determine number of CPUs: /sys/devices/system/cpu/possible: No such file or directory
       success createSchemaCustomization - 0.340s
warning The gatsby-transformer-sharp plugin has generated no Gatsby nodes. Do you need it?
       success Checking for changed pages - 0.000s
       success source and transform nodes - 0.191s
       success building schema - 0.785s
       info Total nodes: 93, SitePage nodes: 8 (use --verbose for breakdown)
       success createPages - 0.059s
       success Checking for changed pages - 0.000s
       success createPagesStatefully - 0.122s
       success update schema - 0.053s
       success onPreExtractQueries - 0.001s
       success extract queries from components - 0.883s
       success write out redirect data - 0.001s
       success Build manifest and related icons - 0.191s
       success onPostBootstrap - 0.193s
       info bootstrap finished - 8.065s
       success run static queries - 0.020s - 3/3 152.93/s
       success run page queries - 1.230s - 10/10 8.13/s
       success write out requires - 0.005s
       success Building production JavaScript and CSS bundles - 55.747s
lscpu: failed to determine number of CPUs: /sys/devices/system/cpu/possible: No such file or directory
       success Rewriting compilation hashes - 0.002s
       success Building HTML renderer - 16.030s
       success Building static HTML for pages - 1.585s - 10/10 6.31/s
       success onPostBuild - 0.011s
       info Done building in 83.211790201 sec
       Done in 84.52s.
       
-----> Caching build
       Saving 1 cacheDirectories (package.json):
       - node_modules
       
-----> Pruning devDependencies
       yarn install v1.22.10
       [1/4] Resolving packages...
       [2/4] Fetching packages...
       warning [email protected]: Invalid bin field for "url-loader".
       info [email protected]: The platform "linux" is incompatible with this module.
       info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
       info [email protected]: The platform "linux" is incompatible with this module.
       info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
       [3/4] Linking dependencies...
       warning " > [email protected]" has unmet peer dependency "jquery@>=1.8.0".
       [4/4] Building fresh packages...
       warning Ignored scripts due to flag.
       Done in 87.39s.
       
-----> Build succeeded!
 !     Unmet dependencies don't fail yarn install but may cause runtime issues
       https://github.com/npm/npm/issues/7494
-----> Discovering process types
       Procfile declares types     -> (none)
       Default types for buildpack -> web
-----> Compressing...
       Done: 158M
-----> Launching...
       Released v6
       https://cml-dev-feat-doc-eu2om6fsnjnfr.herokuapp.com/ deployed to Heroku

Application logs:

2021-06-10T09:43:11.862994+00:00 app[web.1]: �[0m  �[0m�[90m-�[0m �[0m�[93mloader�[0m�[90m:�[0m�[93m996�[0m�[37m �[0m�[37mModule.require�[0m
2021-06-10T09:43:11.862995+00:00 app[web.1]: �[0m  �[0m  �[0m�[90mnode:internal/modules/cjs/loader:996:19�[0m
2021-06-10T09:43:11.862995+00:00 app[web.1]: �[0m  �[0m
2021-06-10T09:43:11.862995+00:00 app[web.1]: �[0m
2021-06-10T09:43:15.586022+00:00 heroku[web.1]: Process exited with status 1
2021-06-10T09:43:15.795734+00:00 heroku[web.1]: State changed from starting to crashed
2021-06-10T12:07:01.902597+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=cml-dev-feat-doc-eu2om6fsnjnfr.herokuapp.com request_id=f80c8c6f-bf2c-4994-90ec-df1791219190 fwd="47.220.230.154" dyno= connect= service= status=503 bytes= protocol=https
2021-06-10T12:07:02.516710+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=cml-dev-feat-doc-eu2om6fsnjnfr.herokuapp.com request_id=a446a0a2-6b01-453e-9e7c-7c2afb88e51a fwd="47.220.230.154" dyno= connect= service= status=503 bytes= protocol=https
2021-06-10T12:08:15.832784+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=cml-dev-feat-doc-eu2om6fsnjnfr.herokuapp.com request_id=f312a7a4-4c93-4250-8e3b-f0c254d5a9df fwd="47.220.230.154" dyno= connect= service= status=503 bytes= protocol=https
2021-06-10T12:08:16.278830+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=cml-dev-feat-doc-eu2om6fsnjnfr.herokuapp.com request_id=a8d05bb2-0409-4369-be38-5272f83ab926 fwd="47.220.230.154" dyno= connect= service= status=503 bytes= protocol=https

@shcheklein shcheklein temporarily deployed to cml-dev-feat-doc-eu2om6fsnjnfr June 10, 2021 13:54 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-feat-doc-eu2om6fsnjnfr June 10, 2021 14:38 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-feat-doc-eu2om6fsnjnfr June 10, 2021 14:49 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-feat-doc-eu2om6fsnjnfr June 10, 2021 15:16 Inactive
@shcheklein shcheklein had a problem deploying to cml-dev-feat-doc-eu2om6fsnjnfr June 10, 2021 16:16 Failure
@shcheklein shcheklein temporarily deployed to cml-dev-feat-doc-eu2om6fsnjnfr June 10, 2021 16:41 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-feat-doc-eu2om6fsnjnfr June 10, 2021 16:51 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-feat-doc-eu2om6fsnjnfr June 10, 2021 17:28 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-feat-doc-eu2om6fsnjnfr June 10, 2021 17:47 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-feat-doc-eu2om6fsnjnfr June 10, 2021 18:10 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-feat-doc-eu2om6fsnjnfr June 14, 2021 03:25 Inactive
module.exports = [
{
matches: 'dvc.yaml',
url: '/doc/user-guide/project-structure/pipelines-files'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these links will be broken on this website

{
resolve: `gatsby-plugin-google-analytics`,
options: {
trackingId: `UA-120072346-5`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which one do we use now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may use the env variable. May I change it as a static one?
Line 172

if (process.env.CONTEXT === 'production') {
  plugins.push({
    resolve: 'gatsby-plugin-google-analytics',
    options: {
      respectDNT: true,
      trackingId: process.env.GA_ID
    }
  })
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we can (and should use) env var I think

@shcheklein shcheklein temporarily deployed to cml-dev-feat-doc-eu2om6fsnjnfr July 11, 2021 18:31 Inactive
@shcheklein shcheklein merged commit d2cef2b into master Jul 12, 2021
@casperdcl casperdcl deleted the feat/doc branch July 12, 2021 20:29
@charnysh-dev charnysh-dev mentioned this pull request Jul 14, 2021
@casperdcl casperdcl mentioned this pull request Jul 27, 2021
@casperdcl casperdcl linked an issue Jul 27, 2021 that may be closed by this pull request
@casperdcl casperdcl linked an issue Jul 27, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs engine request Add pre-commit hooks similar to dvc.org
6 participants