Revert conditional chaining (#966)

* Revert conditional chaining * Apply suggestions from code review Co-authored-by: DavidGOrtega <[email protected]> * lint fix Co-authored-by: DavidGOrtega <[email protected]>
iterative · Apr 14, 2022 · 3a45186 · 3a45186 · github-actions · Apr 15, 2022
1 parent e51531f
commit 3a45186
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/drivers/bitbucket_cloud.js b/src/drivers/bitbucket_cloud.js
@@ -379,9 +379,12 @@ class BitbucketCloud {
       // Attempt to get additional context. We have observed two different error schemas
       // from BitBucket API responses: `{"error": {"message": "Error message"}}` and
       // `{"error": "Error message"}`, apart from plain text responses like `Bad Request`.
-      const error =
-        responseBody?.error?.message || responseBody?.error || responseBody;
-      throw new Error(`${response.statusText} ${error}`.trim());
+      const { error } = responseBody.error
+        ? responseBody
+        : { error: responseBody };
+      throw new Error(
+        `${response.statusText} ${error.message || error}`.trim()
+      );
     }
 
     return responseBody;