Fix signed url versioning #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #755 +/- ##
==========================================
+ Coverage 87.29% 87.35% +0.05%
==========================================
Files 116 116
Lines 11084 11092 +8
Branches 1521 1522 +1
==========================================
+ Hits 9676 9689 +13
+ Misses 1028 1024 -4
+ Partials 380 379 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shcheklein
force-pushed
the
fix-versioning
branch
from
e225bbf to
4987445
Compare
shcheklein
force-pushed
the
fix-signed-url-versioning
branch
from
7a4f9cd to
4333400
Compare
Deploying datachain-documentation with
|
| Latest commit: |
f404d75
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a69670fc.datachain-documentation.pages.dev |
| Branch Preview URL: | https://fix-signed-url-versioning.datachain-documentation.pages.dev |
shcheklein
force-pushed
the
fix-signed-url-versioning
branch
from
4333400 to
e9a95a9
Compare
dreadatour
approved these changes
Dec 28, 2024
shcheklein
force-pushed
the
fix-signed-url-versioning
branch
from
e9a95a9 to
cbf92d1
Compare
shcheklein
force-pushed
the
fix-signed-url-versioning
branch
from
cbf92d1 to
1402c6a
Compare
shcheklein
force-pushed
the
fix-signed-url-versioning
branch
from
1402c6a to
4bf83b8
Compare
shcheklein
force-pushed
the
fix-signed-url-versioning
branch
from
4bf83b8 to
df4e2d4
Compare
shcheklein
force-pushed
the
fix-signed-url-versioning
branch
from
df4e2d4 to
6de95f0
Compare
shcheklein
force-pushed
the
fix-signed-url-versioning
branch
from
6de95f0 to
3e8e810
Compare
shcheklein
force-pushed
the
fix-signed-url-versioning
branch
from
3e8e810 to
d243fdf
Compare
shcheklein
force-pushed
the
fix-signed-url-versioning
branch
from
d243fdf to
6179267
Compare
shcheklein
force-pushed
the
fix-signed-url-versioning
branch
from
6179267 to
84885bc
Compare
shcheklein
force-pushed
the
fix-signed-url-versioning
branch
from
84885bc to
f404d75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes signed URL for versioned objects (download button is broken atm in Studio for versioned buckets, video previews are probably broken since we are also generating singed URLs for them).
https://github.com/iterative/studio/pull/11128 - Studio part
TODO
Followup
Public S3 and Azure
client.url()code. Similar to GS that already has a check foranonin it - we need to generate and return direct URL to the cloud storage.Make sure along the way:
msheader to signed URL to get a public URL that actually works (see some SO discussions)