use windows-2025 image for testing examples #784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying datachain-documentation with
|
| Latest commit: |
2027306
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://147f38c3.datachain-documentation.pages.dev |
| Branch Preview URL: | https://update-windows-image.datachain-documentation.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #784 +/- ##
=======================================
Coverage 87.33% 87.33%
=======================================
Files 128 128
Lines 11181 11181
Branches 1514 1514
=======================================
Hits 9765 9765
Misses 1041 1041
Partials 375 375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0x2b3bfa0
approved these changes
Jan 5, 2025
There was a problem hiding this comment.
- This "error" seems to be just a warning. 🤔
- Are you sure bumping to a new Windows Server version will fix the issue?, see https://github.com/microsoft/onnxruntime/blob/2a16ad0215a8e0fb38218b8def1f364ef34829ac/onnxruntime/python/onnxruntime_validation.py#L25
Still, I'm not opposed to merge this and try.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if this will fix the error but you can see one here and the list of available images is here (2025 is beta).
We can always try and then revert.