freeze: convert to 1.0 #1488
Merged
freeze: convert to 1.0 #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeorpinel
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
Thanks @pared I'll just remove those output lines from other commands that aren't freeze/unfreeze. Easier to maintain without them.
| Running command: | ||
| cp foo bar | ||
| ... | ||
| $ dvc run -d foo -o bar -n make_copy cp foo bar |
There was a problem hiding this comment.
Should we put -n first?
Suggested change
| $ dvc run -d foo -o bar -n make_copy cp foo bar | |
| $ dvc run -n make_copy -d foo -o bar cp foo bar |
|
thanks @pared ! |
jorgeorpinel
added a commit
that referenced
this pull request
Jun 24, 2020
|
Continued in #1493 |
shcheklein
pushed a commit
that referenced
this pull request
Jun 25, 2020
* cmd ref: add more explanations to freeze per #1488 (review) et al. * cmd ref: more updates to freeze * cmd ref: updates to unfreeze based on those to freeze see recent commits * cmd ref: revise examples of (un)freeze refs. * cmd: fix examples in (un)freeze per #1493 (review) * cmd: rewrite intros to (un)freeze per #1493 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Related to #1255