Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unfreeze: move to 1.0 #1495

Closed
wants to merge 1 commit into from
Closed

Conversation

pared
Copy link
Contributor

@pared pared commented Jun 24, 2020

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.

Please choose to allow us to edit your branch when creating the PR.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Related to #1255

@@ -44,7 +44,7 @@ First, let's create a simple DVC-file:
```dvc
$ echo foo > foo
$ dvc add foo
$ dvc run -d foo -o bar -n make_copy cp foo bar
$ dvc run -n make_copy -d foo -o bar cp foo bar
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foo.dvc
outs
changed: foo
$ dvc unfreeze make_copy
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/iterative/dvc.org/pull/1488/files#r444374258

I think there is no need to put the statement in the end, as it is stated in the beginning:
"Run dvc unfreeze to unfreeze it back."

@@ -77,12 +77,4 @@ Run `dvc unfreeze` to unfreeze it back:

```dvc
$ dvc unfreeze make_copy
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/iterative/dvc.org/pull/1488/files#r444374258

I think there is no need to put the statement in the end, as it is stated in the beginning:
"Run dvc unfreeze to unfreeze it back."

@pared pared requested a review from jorgeorpinel June 24, 2020 08:09
@jorgeorpinel
Copy link
Contributor

Oops, looks like a duplicate of #1493 ?

@pared
Copy link
Contributor Author

pared commented Jun 24, 2020

My bad forgot te check existing PR's today, sorry @jorgeorpinel. Will find some other article to mess around with!

@pared pared closed this Jun 24, 2020
@jorgeorpinel
Copy link
Contributor

No sorry, it looks like I took over your planned docs contributions! If you could help us review that other one that would be great too :) maybe some of your comments up here apply? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants