-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unfreeze: move to 1.0 #1495
unfreeze: move to 1.0 #1495
Conversation
@@ -44,7 +44,7 @@ First, let's create a simple DVC-file: | |||
```dvc | |||
$ echo foo > foo | |||
$ dvc add foo | |||
$ dvc run -d foo -o bar -n make_copy cp foo bar | |||
$ dvc run -n make_copy -d foo -o bar cp foo bar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
foo.dvc | ||
outs | ||
changed: foo | ||
$ dvc unfreeze make_copy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/iterative/dvc.org/pull/1488/files#r444374258
I think there is no need to put the statement in the end, as it is stated in the beginning:
"Run dvc unfreeze
to unfreeze it back."
@@ -77,12 +77,4 @@ Run `dvc unfreeze` to unfreeze it back: | |||
|
|||
```dvc | |||
$ dvc unfreeze make_copy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/iterative/dvc.org/pull/1488/files#r444374258
I think there is no need to put the statement in the end, as it is stated in the beginning:
"Run dvc unfreeze to unfreeze it back."
Oops, looks like a duplicate of #1493 ? |
My bad forgot te check existing PR's today, sorry @jorgeorpinel. Will find some other article to mess around with! |
No sorry, it looks like I took over your planned docs contributions! If you could help us review that other one that would be great too :) maybe some of your comments up here apply? Thanks! |
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue
(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Related to #1255