-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
term: remove Dvcfile from repro cmd ref. #1504
Conversation
@jorgeorpinel I guess the -c and -R options in |
This comment has been minimized.
This comment has been minimized.
Hi @sarthakforwet this PR does not resolve #1445 completely so please don't use that special term in the description because it would cause #1445 to be closed if this is merged. |
`dvc repro` relies on the DAG definition that it reads from `dvc.yaml`, and uses | ||
`dvc.lock` to determine what exactly needs to be run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks but this is out of scope for this PR. The whole cmd ref. needs to be rewritten so no use in adding a small update here, probably. Unless it was needed to explain the Dvcfile removal but I don' think that's the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok Sure! will add it later when updating command reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #1572
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good overall but I left some specific comments.
I would recommend that after this PR is merged you try to help fully updating the whole dvc repro
command reference for 1.0. That means the description and options, since it seems you already updated the examples accordingly 🙂
Co-authored-by: Jorge Orpinel <[email protected]>
Co-authored-by: Jorge Orpinel <[email protected]>
Co-authored-by: Jorge Orpinel <[email protected]>
@jorgeorpinel I intend to completely solve that issue here. |
Yeah sure! would love to do that 😁 |
Let's not do this @sarthakforwet. It's a best practice to make PRs small (easy to review), get them merged, and then work on the remaining work in other PRs. I changed the title of this PR to reflect it's scope. So again, please don't use that special term in the description because it would cause #1445 to be closed. Thanks P/s but it would be much more useful if you help entirely updating the |
Sure, can you guide me with the relevant issues or should I open a new PR dedicated to completely update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙂
@sarthakforwet yes, this would be useful definitely. But again, no pressure in these any more. I think we've established good collaboration. I recommend you focus on polishing your GSoD application and share it with me for feedback if you haven't. We'll have the rest of July for collaborating on Gtihub. |
Thanks for your contributions BTW! |
yeah sure! Thanks! |
Pleasure! and thanks for support. |
The following PR completes one subtask of #1445 by removing/updating
Dvcfile
fromrepro.md
.This issue has also been referenced under #1255 .
Updations:
dvc repro
to the new one.dvc run
command in Examples.