-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipeline: links and examples update for 1.x #1584
Merged
Merged
Changes from 8 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8041f9f
pipeline links changed
utkarshsingh99 63d646e
removed wrong links
utkarshsingh99 6db870f
removed unwanted pipeline links
utkarshsingh99 afeb4cf
push/pull example updated: dvc dag
utkarshsingh99 1dee601
links in use-cases, user-guide
utkarshsingh99 83f1b85
grammar fixes
utkarshsingh99 d28a1cb
updated pull example with temp incorrect output
utkarshsingh99 d4f6d0b
Update content/docs/use-cases/versioning-data-and-model-files/tutoria…
jorgeorpinel 05a45ee
reverting grammar fix in what-is-dvc/collaboration-issues
utkarshsingh99 6863bca
Merge branch 'patch16' of github.com:utkarshsingh99/dvc.org into patch16
utkarshsingh99 2fd945a
update use-cases/versioning/tutorial.md
utkarshsingh99 0b57d52
review changes
utkarshsingh99 177e34c
output update
utkarshsingh99 176e934
update output
utkarshsingh99 e45b951
update push/pull examples - stage names
utkarshsingh99 255db0d
update stage names in prev para - push.md
utkarshsingh99 a5f18e1
update outputs with blockquotes
utkarshsingh99 d7959b9
review changes - last
utkarshsingh99 89057d5
Example update: pull, undo line deletion: push
utkarshsingh99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the output here because it's a relatively less incorrect output than the previous one.
Unfortunately, the remote still isn't working. I cannot find the output of
evaluate.dvc
since it doesn't exist. Also, files insrc/
are Git-tracked files, so I had to remove them from git. Even after adding all files (dvc add
) insrc/
,dvc dag evaluate.py.dvc
does not show the linked files either. I suppose I am missing something and having the remote changed would result in an accurate output. This output is the output I'm currently getting.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's totally wrong 😋 please read the cmd ref at https://dvc.org/doc/command-reference/dag and notice the https://github.com/iterative/example-get-started project has been updated for 1.x already. There are no .dvc stage files, it's all in dvc.yaml. Have you followed the new Get Started at https://dvc.org/doc/start?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also you don't need to use a target in
dvc dag
, just the plan command should be enough... But it will print a diagram which may be too long. If it seems to (too long) just usecat dvc.yaml
here as well. ThanksThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind. cat dvc.yaml will bee way too long here also. Let's try
dvc dag
with the right targetplease. Lmk if you need help... But do read those refs I shared, hopefully you'll get it from that. ThanksThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I've updated it with
dvc dag evaluate
, but it still gave the entire diagram as output.Because the
deps
files link all the way back toprepare
andfeaturize
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Yeah I contradicted myself, sorry... You don't need to use a target in
dvc dag
. The plan command should show everything by default.But I think we're gonna have to go with a simple list of stage names like in push, because this diagram is too huge.
The rest of the example will also need updating here, so it makes sense (similar to the changes in https://github.com/iterative/dvc.org/pull/1591/files). Please try to make sure the entire context makes sense and works. Thanks
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh okay, I got your point. But a problem arises as stated in #1584(comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the issue. It's just a matter of updating the rest of the example please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the other missing point but we can extract into a separate issue. Are you having trouble understanding what I meant here about updating the rest of the example @utkarshsingh99 ? Thanks