Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: some example updates as per 1.x #1903

Merged
merged 9 commits into from
Nov 22, 2020
Merged

cmd: some example updates as per 1.x #1903

merged 9 commits into from
Nov 22, 2020

Conversation

imhardikj
Copy link
Contributor

@imhardikj imhardikj commented Nov 1, 2020 •
edited by jorgeorpinel
Loading

  • fetch example
  • get example
  • pull example

Partially addresses #1824

@shcheklein shcheklein temporarily deployed to dvc-landing-cmdref-exam-yfd1wj November 1, 2020 13:54 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-cmdref-exam-yfd1wj November 1, 2020 14:00 Inactive
@jorgeorpinel jorgeorpinel mentioned this pull request Nov 5, 2020
Closed
12 tasks
jorgeorpinel
jorgeorpinel suggested changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing fetch only for now:

@imhardikj the updates so far seem correct but we are missing to read the whole section from the beginning and make sure it still makes sense. Specifically, the Click and expand to setup the project expandable section already runs dvc fetch so after doing that, ...

p.s. and actually run every command and update the output of tree if you have to, even if it's just a bunch of md5 hashes. Thanks

@imhardikj

This comment has been minimized.

Sign in to view
@restyled-io restyled-io bot mentioned this pull request Nov 16, 2020
Closed
@jorgeorpinel jorgeorpinel changed the title Cmd ref example updates as per 1.x cmd: some example updates as per 1.x Nov 22, 2020
jorgeorpinel
jorgeorpinel suggested changes Nov 22, 2020
View reviewed changes
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Finally getting this done! Thanks to @imhardikj 👍

jorgeorpinel
jorgeorpinel approved these changes Nov 22, 2020
View reviewed changes
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to approve 🙄

@jorgeorpinel jorgeorpinel merged commit 49859c1 into master Nov 22, 2020
@jorgeorpinel jorgeorpinel deleted the cmdref/examples branch November 28, 2020 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeorpinel jorgeorpinel jorgeorpinel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imhardikj @jorgeorpinel @shcheklein