Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent indentation in status examples #1912

Closed
wants to merge 4 commits into from
Closed

Conversation

imhardikj
Copy link
Contributor

@imhardikj imhardikj commented Nov 6, 2020

Partially Addresses #1824:

  • status examples in all docs (including consistent indentation — may keep tabs)

@shcheklein shcheklein temporarily deployed to dvc-landing-statuscmd-7kymn8ex November 6, 2020 19:01 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-statuscmd-7kymn8ex November 8, 2020 13:34 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-statuscmd-7kymn8ex November 8, 2020 13:57 Inactive
@jorgeorpinel
Copy link
Contributor

@imhardikj is this ready for review? I see it's still in draft status.

Comment on lines +174 to +176
This shows that for stage `bar`, the dependency `bar` and the
<abbr>output</abbr> `foo` have changed. Likewise for `foo.dvc`, the output `foo`
has changed, but no dependency has changed.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgeorpinel didn't make it ready for review as many PRs were open.
Currently I have changed indentation in only 3 files. I have kept a tab (8 spaces) for indentation. If this is correct I'll do it for all docs.
Also this example in status.md looked outdated so changed this too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you're already working on 2 PRs so let's focus on those please. Or do you have any extra/idle time to do this too?

@imhardikj imhardikj marked this pull request as ready for review November 12, 2020 19:50
Comment on lines -159 to +161
bar.dvc:
changed deps:
modified: bar
bar:
changed deps:
modified: bar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for the changes. If this is what DVC outputs, then it is correct. We'll trust you on this one to actually run each commit.

@jorgeorpinel
Copy link
Contributor

But again, since there's 2 active PRs I'll close this for now. Feel free to keep the branch of course and keep working on it locally for when there's a chance to reopen this. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants