-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent indentation in status examples #1912
Conversation
@imhardikj is this ready for review? I see it's still in draft status. |
This shows that for stage `bar`, the dependency `bar` and the | ||
<abbr>output</abbr> `foo` have changed. Likewise for `foo.dvc`, the output `foo` | ||
has changed, but no dependency has changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorgeorpinel didn't make it ready for review as many PRs were open.
Currently I have changed indentation in only 3 files. I have kept a tab (8 spaces) for indentation. If this is correct I'll do it for all docs.
Also this example in status.md
looked outdated so changed this too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you're already working on 2 PRs so let's focus on those please. Or do you have any extra/idle time to do this too?
bar.dvc: | ||
changed deps: | ||
modified: bar | ||
bar: | ||
changed deps: | ||
modified: bar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for the changes. If this is what DVC outputs, then it is correct. We'll trust you on this one to actually run each commit.
But again, since there's 2 active PRs I'll close this for now. Feel free to keep the branch of course and keep working on it locally for when there's a chance to reopen this. Thanks |
Partially Addresses #1824: