Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get started tutorial for experiments (with readable diff) #2195

Merged
merged 46 commits into from
Feb 27, 2021

Conversation

dberenbaum
Copy link
Contributor

@dberenbaum dberenbaum commented Feb 15, 2021

Creating a new PR and closing out #2191 due to diff readability issues. You will still need to go to the individual commit to see a clean diff of the old experiments section: 92e66cb.

Fix #2189.

@shcheklein
Copy link
Member

@dberenbaum it looks great! I have a few concerns - mostly about the title - ML pipelines. It's a low hanging fruit that can be fixed/improved now. Section about comparing differences, and videos also feels artificial a bit in the "ML pipelines".

Regarding the new material. Do we have/want to cover the way to share/save experiments (exp push?)?

@shcheklein shcheklein temporarily deployed to dvc-org-experiments-res-3qhgnc February 16, 2021 22:31 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-experiments-res-3qhgnc February 17, 2021 21:03 Inactive
@shcheklein
Copy link
Member

@jorgeorpinel can you do the final check (major concerns) and if it looks good, let's merge it? or should we wait when we actually publish the pre-release version, @dberenbaum ?

@dberenbaum
Copy link
Contributor Author

dberenbaum commented Feb 18, 2021

The pre-release package is already published, although the blog post isn't up yet. I'm not worried about the timing. I have two questions:

  1. I was working on the push/pull section but am not that happy with it. Should we make that a separate PR?
  2. Do we need an only available in 2.0 tag for this?

@shcheklein
Copy link
Member

@dberenbaum

I was working on the push/pull section but am not that happy with it. Should we make that a separate PR?

Up to you, PR is approved already, so we can merge and iterate on top of it.

Do we need an only available in 2.0 tag for this?

I think it can be helpful, yes.

@shcheklein shcheklein temporarily deployed to dvc-org-experiments-res-3qhgnc February 18, 2021 14:17 Inactive
@dberenbaum
Copy link
Contributor Author

A couple of issues to note before merging:

  • Some of the links aren't yet active (/docs/command-reference/exp and /doc/user-guide/experiment-management)
  • The example-get-started repo isn't updated yet

@shcheklein shcheklein temporarily deployed to dvc-org-experiments-res-3qhgnc February 18, 2021 20:38 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-experiments-res-3qhgnc February 25, 2021 16:11 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-experiments-res-3qhgnc February 25, 2021 19:35 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-experiments-res-3qhgnc February 25, 2021 21:13 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-experiments-res-3qhgnc February 25, 2021 22:09 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-experiments-res-3qhgnc February 25, 2021 22:17 Inactive
@dberenbaum
Copy link
Contributor Author

@jorgeorpinel I'm finished responding to comments, so take another look when you have time.

@shcheklein shcheklein temporarily deployed to dvc-org-experiments-res-3qhgnc February 26, 2021 04:04 Inactive
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor follow ups but this looks amazing!

@shcheklein shcheklein temporarily deployed to dvc-org-experiments-res-3qhgnc February 26, 2021 22:49 Inactive
@dberenbaum
Copy link
Contributor Author

Thanks, @jorgeorpinel and @shcheklein! Will one of you merge when you are ready (or grant me access)?

* add metrics/plots show in get started

* try image resize

* revert image resize

* try to resize directly

* Update plots_prc_get_started_show.svg

* Update plots_roc_get_started_show.svg

Co-authored-by: Ivan Shcheklein <[email protected]>
@shcheklein shcheklein temporarily deployed to dvc-org-experiments-res-3qhgnc February 27, 2021 00:29 Inactive
@dberenbaum dberenbaum merged commit 031b06b into master Feb 27, 2021
@dberenbaum dberenbaum deleted the experiments_reset branch February 27, 2021 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Section for dvc exp in https://dvc.org/doc/start/experiments
3 participants