-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get started tutorial for experiments (with readable diff) #2195
Conversation
@dberenbaum it looks great! I have a few concerns - mostly about the title - ML pipelines. It's a low hanging fruit that can be fixed/improved now. Section about comparing differences, and videos also feels artificial a bit in the "ML pipelines". Regarding the new material. Do we have/want to cover the way to share/save experiments (exp push?)? |
@jorgeorpinel can you do the final check (major concerns) and if it looks good, let's merge it? or should we wait when we actually publish the pre-release version, @dberenbaum ? |
The pre-release package is already published, although the blog post isn't up yet. I'm not worried about the timing. I have two questions:
|
Up to you, PR is approved already, so we can merge and iterate on top of it.
I think it can be helpful, yes. |
A couple of issues to note before merging:
|
Co-authored-by: Jorge Orpinel <[email protected]>
@jorgeorpinel I'm finished responding to comments, so take another look when you have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor follow ups but this looks amazing!
Thanks, @jorgeorpinel and @shcheklein! Will one of you merge when you are ready (or grant me access)? |
* add metrics/plots show in get started * try image resize * revert image resize * try to resize directly * Update plots_prc_get_started_show.svg * Update plots_roc_get_started_show.svg Co-authored-by: Ivan Shcheklein <[email protected]>
Creating a new PR and closing out #2191 due to diff readability issues. You will still need to go to the individual commit to see a clean diff of the old experiments section: 92e66cb.
Fix #2189.