Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive synopsis Fix #2024 #3140
Interactive synopsis Fix #2024 #3140
Changes from 18 commits
fe55d51
7eb7a3c
d2491c4
0357010
2db56e1
551aae5
65cd894
0897dbe
aced399
532c3ec
5ab5723
f433cc9
fee75df
1ff0a76
1d98d06
8392d9f
9ed8ed8
27960ac
b8d44a4
ce1530f
d083248
6515b73
6013dd2
3debb34
aebacd4
ee52a0e
301b0aa
b99fd5c
59363d3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will it match lists like "- some text
--flag
"? also does it mean that we math lists outside theOptions
section?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it matches list with 1st line start with inline Code block i.e `` and that starts with
-
. Yes, If it exactly matches this then it's possible outside options too. We can work on this more if it collide but I found that unique for my quick overlook over the docs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have a list that matches the pattern in our DVCLive docs: https://dvc-org-interactive-syn-zo8hwd.herokuapp.com/doc/dvclive/dvclive-with-dvc#--live-no-cache. Not sure if it does any harm to have links there... Though if we wanted, we could have
gatsby-remark-args-linker
only look through pages in our/command-reference/
directory 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, Julie and Thomas. q: how hard it is to make it strict and well-defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The possible way I could think of was to make it strict or well defined is by checking heading Options and looking into a consecutive list and to the list item.
But, I found it difficult to do so with Markdown AST. We could easily achieve that if we had something easy/well-defined APIs/functions as in DOM manipulation. Otherwise, we need to come up with some hacky way to do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, but it's also about replacing
node.children.some
with something likenode.children.first
'docs/command-reference' - we need to make it a param? since it might be different across different websites later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would check the first child in the list, right? While this would work for almost all use cases
/repro
options starts withtargets
:It is the only one as far as I know though :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops sorry, I missed this conversation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the params for paths which can be a string(path) or an array of paths. For now, I have set it to
docs/command-reference
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made some changes and pushed.