Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DocSearch #3931

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Update DocSearch #3931

merged 2 commits into from
Sep 9, 2022

Conversation

yathomasi
Copy link
Contributor

@yathomasi yathomasi requested a review from a team September 9, 2022 09:11
@shcheklein shcheklein temporarily deployed to dvc-org-update-docssear-vwysnn September 9, 2022 09:11 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Link Check Report

All 2 links passed!

rogermparent
rogermparent approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@rogermparent rogermparent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to update the theme so we can use less copy-and-paste code in the consumer repos here, but this works in the meantime.

@yathomasi
Copy link
Contributor Author

We'll want to update the theme so we can use less copy-and-paste code in the consumer repos here, but this works in the meantime.

The simplest solution would be using the environmental variables to obtain the key values. We already have an issue open for it, we just need to bump the priority.

@yathomasi yathomasi merged commit 5f69847 into main Sep 9, 2022
@yathomasi yathomasi deleted the update-docssearch branch September 9, 2022 16:20
@jorgeorpinel jorgeorpinel added the dependencies Pull requests that update a dependency file (automatic) label Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogermparent rogermparent rogermparent approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file (automatic)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yathomasi @rogermparent @jorgeorpinel @shcheklein