-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add doc about foreach target #3989
Conversation
Link Check ReportThere were no links to check! |
@@ -12,7 +12,7 @@ usage: dvc checkout [-h] [-q | -v] [--summary] [-d] [-R] [-f] | |||
|
|||
positional arguments: | |||
targets Limit command scope to these tracked files/directories, | |||
.dvc files, or stage names. | |||
.dvc files and stage or foreach-group names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if people would know what foreach-group
means.
It is not used in https://dvc.org/doc/user-guide/project-structure/dvcyaml-files#foreach-stages which are the only existing docs for foreach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I don't think this change is needed TBH: foreach groups ultimately become stages so it's covered with "or stage names". No need to be that super explicit about every possible syntax in the help output, especially for such an advanced feature (not that used from what I understand).
- Explaining that you can target them in the foreach docs linked above should be enough IMO.
Thanks, @skshetry!
Should we add a |
targets Limit command scope to these tracked files/directories, | ||
.dvc files and stage or foreach-group names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the syntax here is unclear. Probably revert to a comma if we keep this? Maybe
targets Limit command scope to these tracked files/directories, | |
.dvc files and stage or foreach-group names. | |
targets Limit command scope to these tracked files/directories, | |
.dvc files, stage (or foreach) names. |
Adding that to
|
Closed in favor of #4010 |
Syncing with iterative/dvc#8352. I am skipping
repro
andexp run
because they are well discussed in the Options sections, and we wanted to avoid describing too much and took the example-based approach in the docs.See #1983. The support for foreach group name in the target was extended in iterative/dvc#8210.