Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: H2->3 in <details> sections #4093

Merged
merged 2 commits into from
Nov 2, 2022
Merged

fix: H2->3 in <details> sections #4093

merged 2 commits into from
Nov 2, 2022

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Nov 1, 2022

so that they don't show up in the right ✋🏼 CONTENT sidebar; E.g.:

image

Current https://dvc.org/doc/start/data-management/data-versioning

so they don't show up in the CONTENTS sidebar (right)
@jorgeorpinel jorgeorpinel added A: docs Area: user documentation (gatsby-theme-iterative) p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. labels Nov 1, 2022
@shcheklein shcheklein temporarily deployed to dvc-org-fix-details-h3-iqxpiam November 1, 2022 19:54 Inactive
@jorgeorpinel
Copy link
Contributor Author

Cc @iterative/websites is this the right approach, of should the engine ignore headers from <details> sections? Minor. Thanks

@jorgeorpinel jorgeorpinel added the website: ux Website UI/UX label Nov 1, 2022
@jorgeorpinel jorgeorpinel requested a review from a team November 1, 2022 19:55
@rogermparent
Copy link
Contributor

I'm honestly not sure what the proper approach would be for this, but if we want to prevent details blocks from showing up in the content nav that could be a totally viable feature- I don't think we deliberately set it to act either way, I think the headers data used for the content nav feature actually comes directly from gatsby-plugin-remark so we don't have great control over it currently.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

bb249ff

Link Check Report

There were no links to check!

@shcheklein shcheklein temporarily deployed to dvc-org-fix-details-h3-iqxpiam November 1, 2022 21:52 Inactive
Copy link
Contributor

@rogermparent rogermparent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright by me! I'll follow up by discussing a more proper way details headers during next websites meeting. Feel free to give any ideas!

@jorgeorpinel
Copy link
Contributor Author

It's nor a big deal, prob not worth addressing at this point. On the other hand I keep noticing iterative/gatsby-theme-iterative#38 so may be something to check whether it's easy to fix.

@jorgeorpinel jorgeorpinel merged commit bb249ff into main Nov 2, 2022
@jorgeorpinel jorgeorpinel deleted the fix/details-h3 branch November 2, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. website: ux Website UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants