Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Studio Self hosted docs to dvc.org #4344

Merged
merged 17 commits into from
Mar 9, 2023
Merged

Conversation

jesper7
Copy link
Contributor

@jesper7 jesper7 commented Mar 1, 2023

This PR migrates all of our Studio Selfhosted docs on Notion and Github to dvc.org.

Contents

  • Installation
    • AMI
    • Helm
  • Configuration
    • TLS
    • GitLab integration
    • GitHub integration
  • Troubleshooting

@jesper7 jesper7 added the C: studio Content of /doc/studio; github.com/iterative/studio/labels/A%3A%20help%20%26%20docs%20%26%20media label Mar 1, 2023
@jesper7 jesper7 requested a review from omesser March 1, 2023 18:49
@jesper7 jesper7 self-assigned this Mar 1, 2023
@jesper7 jesper7 requested a review from a team as a code owner March 1, 2023 18:49
@shcheklein shcheklein temporarily deployed to dvc-org-studio-selfhost-l2oxcs March 1, 2023 18:52 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Link Check Report

There were no links to check!

@jesper7 jesper7 requested a review from mjasion March 1, 2023 19:46
@shcheklein shcheklein temporarily deployed to dvc-org-studio-selfhost-l2oxcs March 2, 2023 19:43 Inactive
content/docs/sidebar.json Outdated Show resolved Hide resolved
content/docs/studio/selfhosted/installation/index.md Outdated Show resolved Hide resolved
content/docs/studio/selfhosted/installation/index.md Outdated Show resolved Hide resolved
content/docs/studio/selfhosted/installation/ami.md Outdated Show resolved Hide resolved
content/docs/sidebar.json Outdated Show resolved Hide resolved
content/docs/studio/selfhosted/configuration/index.md Outdated Show resolved Hide resolved
content/docs/studio/selfhosted/configuration/tls.md Outdated Show resolved Hide resolved
content/docs/studio/selfhosted/configuration/github.md Outdated Show resolved Hide resolved
using the following installation methods:

- [AMI (AWS)](/doc/studio/selfhosted/installation/ami)
- [Helm (Kubernetes)](/doc/studio/selfhosted/installation/helm)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we address here pre-requisites like setting up SCM repo apps before installation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We provide example configurations in each installation guide and suggest looking at the configuration section before deploying so I think it naturally ends up in that order.

For example, the reader might end up on a path like:
Helm guide -> Configuration -> SCM providers -> GitHub -> Helm guide

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find that the order of operations and an understanding of the high-level steps is something you always want to make crystal clear beforehand and not be "emergent" - it's easy to feel overwhelmed as a reader of a guide if you're jumping back and forth between pages without a high-level ordered-step-list in mind

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. However, there are going to be problems with circular dependencies either way.

For instance, if we implement your suggestion:

  1. User reads the installation methods page and is made aware that Git forges need to be set up before continuing.
  2. User heads over to the GitHub page, sets up the GitHub app, and doesn't know what to do when encountering the YAML config section, e.g., https://dvc-org-studio-selfhost-l2oxcs.herokuapp.com/doc/studio/self-hosting/configuration/github#configuring-studio-with-the-github-app

Can we work around this without it becoming confusing for the user? The only idea I have is a separation of the external (e.g., Github) and the internal (Studio) configuration, but this also leads to indirection.

content/docs/studio/selfhosted/configuration/index.md Outdated Show resolved Hide resolved
@shcheklein shcheklein temporarily deployed to dvc-org-studio-selfhost-l2oxcs March 3, 2023 08:56 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-studio-selfhost-l2oxcs March 3, 2023 09:00 Inactive
content/docs/studio/selfhosted/installation/ami.md Outdated Show resolved Hide resolved
content/docs/studio/selfhosted/installation/ami.md Outdated Show resolved Hide resolved
content/docs/studio/selfhosted/installation/ami.md Outdated Show resolved Hide resolved
content/docs/studio/selfhosted/installation/ami.md Outdated Show resolved Hide resolved
content/docs/studio/selfhosted/installation/ami.md Outdated Show resolved Hide resolved
content/docs/studio/selfhosted/installation/ami.md Outdated Show resolved Hide resolved
content/docs/studio/selfhosted/installation/ami.md Outdated Show resolved Hide resolved
content/docs/studio/selfhosted/installation/ami.md Outdated Show resolved Hide resolved
content/docs/studio/selfhosted/installation/ami.md Outdated Show resolved Hide resolved
@shcheklein shcheklein temporarily deployed to dvc-org-studio-selfhost-l2oxcs March 3, 2023 10:00 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-studio-selfhost-l2oxcs March 3, 2023 16:25 Inactive
@jesper7 jesper7 requested review from mjasion and omesser March 3, 2023 16:45
@shcheklein shcheklein temporarily deployed to dvc-org-studio-selfhost-l2oxcs March 3, 2023 16:45 Inactive
Copy link
Contributor

@omesser omesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jesper7 - Left a few more comments 🙏

content/docs/studio/self-hosting/configuration/github.md Outdated Show resolved Hide resolved
# Optional
# This is useful in cases where Studio is on an internal
# network, but the webhook endpoint is on an external network
# webhookUrl: https://webhook.studio.company.com/webhook/gitlab/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as in github - not clear if this "optional" is because webhooks as a feature are optional, or they will work without setting this explicitly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The webhooks will work if the SCM provider has connectivity with Studio. This wouldn't be the case on an internal network, so users can selectively expose the webhook on an external network so that it still works.

Do you think it needs rephrasing to make this more clear?

# Configuration

Studio uses a standardized, unified YAML configuration file, often referred to
as `values.yaml` in the documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems really weird to me to talk about this without mentioning Helm. This is not just some "unified YAML" (not sure what that even means).
Suggest to add a link here somehow: https://helm.sh/docs/chart_template_guide/values_files/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can, of course, mention Helm. My concern here was with overwhelming AMI users with Kubernetes terminology. There are also plans to move to an interactive installer, so manual configuration eventually becomes obsolete for most users.

This is not just some "unified YAML" (not sure what that even means).

I can see it's confusing, and I'll rephrase it. The point was that the configuration works for both the AMI and Helm flavors.

content/docs/studio/self-hosting/configuration/index.md Outdated Show resolved Hide resolved
content/docs/studio/self-hosting/installation/aws-ami.md Outdated Show resolved Hide resolved
content/docs/studio/self-hosting/installation/aws-ami.md Outdated Show resolved Hide resolved
content/docs/studio/self-hosting/installation/aws-ami.md Outdated Show resolved Hide resolved
content/docs/studio/self-hosting/installation/k8s-helm.md Outdated Show resolved Hide resolved
$ ssh -i <EC2 key pair> ubuntu@$EC2_INSTANCE
```

13. Configure the Docker registry credentials:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we link to the k8s-helm for the rest of the steps?
Seems like a direct duplication, wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean https://github.com/iterative/helm-charts?

I think having the documentation in one place is better for our users. The documentation in the helm-charts repo is also outdated

Copy link
Contributor

@omesser omesser Mar 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jesper7 - I mean installation/k8s-helm.md so cross-linking inside the docs in dvc.org

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I think it's better to have all the steps on one page. We can perhaps see if it's possible to create snippets that can be included across pages

@shcheklein shcheklein had a problem deploying to dvc-org-studio-selfhost-l2oxcs March 6, 2023 12:01 Failure
@shcheklein shcheklein requested a deployment to dvc-org-studio-selfhost-l2oxcs March 6, 2023 12:01 Abandoned
@shcheklein shcheklein requested a deployment to dvc-org-studio-selfhost-l2oxcs March 6, 2023 12:01 Abandoned
@shcheklein shcheklein requested a deployment to dvc-org-studio-selfhost-l2oxcs March 6, 2023 12:01 Abandoned
@shcheklein shcheklein had a problem deploying to dvc-org-studio-selfhost-l2oxcs March 6, 2023 12:03 Failure
@shcheklein shcheklein had a problem deploying to dvc-org-studio-selfhost-l2oxcs March 6, 2023 12:06 Failure
@shcheklein shcheklein had a problem deploying to dvc-org-studio-selfhost-l2oxcs March 6, 2023 12:12 Failure
@shcheklein shcheklein had a problem deploying to dvc-org-studio-selfhost-l2oxcs March 6, 2023 12:13 Failure
@shcheklein shcheklein had a problem deploying to dvc-org-studio-selfhost-l2oxcs March 6, 2023 12:27 Failure
@shcheklein shcheklein had a problem deploying to dvc-org-studio-selfhost-l2oxcs March 6, 2023 13:36 Failure
@yathomasi yathomasi temporarily deployed to dvc-org-studio-selfhost-l2oxcs March 6, 2023 14:10 Inactive
@yathomasi
Copy link
Contributor

@jesper7 updated to the main branch. I assume the initial branch was created from a very old main branch.

"node": ">=14.x <=18.x"

mjasion
mjasion previously requested changes Mar 6, 2023
Copy link
Contributor

@mjasion mjasion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have one input. Other thins LGTM ❤️ 👍

Comment on lines 141 to 145
<admon type="info">

Replace the strings marked with `< >`

</admon>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed at this point.

Suggested change
<admon type="info">
Replace the strings marked with `< >`
</admon>

@shcheklein shcheklein temporarily deployed to dvc-org-studio-selfhost-l2oxcs March 6, 2023 17:33 Inactive
Copy link
Contributor

@omesser omesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jesper7 - nice
There is this from @mjasion , and for me just one open comment, trying to DRY this up a bit

But as we discussed - there is already so much here, and at a good level of polish - Approving 🙏

@omesser omesser changed the title Migrate Studio Selfhosted docs to dvc.org Migrate Studio Self hosted docs to dvc.org Mar 8, 2023
@jesper7 jesper7 merged commit c684c68 into main Mar 9, 2023
@jesper7 jesper7 deleted the studio-selfhosted-docs branch March 9, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: studio Content of /doc/studio; github.com/iterative/studio/labels/A%3A%20help%20%26%20docs%20%26%20media
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants