top-level plot collections: fail on empty dict (#10233)

* top-level plot collections: skip empty dict * tighten schema for plots; require key name
iterative · Jan 12, 2024 · b46bd9c · b46bd9c
1 parent d711ecd
commit b46bd9c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/dvc/repo/plots/__init__.py b/dvc/repo/plots/__init__.py
@@ -487,6 +487,7 @@ def _collect_pipeline_files(repo, targets: List[str], props, onerror=None):
             if isinstance(elem, str):
                 dvcfile_defs_dict[elem] = None
             else:
+                assert elem
                 k, v = next(iter(elem.items()))
                 dvcfile_defs_dict[k] = v
 

diff --git a/dvc/schema.py b/dvc/schema.py
@@ -112,7 +112,7 @@ def validator(data):
     Output.PARAM_PLOT_TITLE: str,
     Output.PARAM_PLOT_TEMPLATE: str,
 }
-SINGLE_PLOT_SCHEMA = {str: vol.Any(PLOT_DEFINITION, None)}
+SINGLE_PLOT_SCHEMA = {vol.Required(str): vol.Any(PLOT_DEFINITION, None)}
 ARTIFACTS = "artifacts"
 SINGLE_ARTIFACT_SCHEMA = vol.Schema({str: ARTIFACT_SCHEMA})
 FOREACH_IN = {