Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add/run/import-url: don't use -f as --file #4004

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Jun 10, 2020

If anything, -f is closer to --force than to --file. So let's set
this straight.

iterative/dvc.org#1255 iterative/dvc.org/issues/1426

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

If anything, `-f` is closer to `--force` than to `--file`. So let's set
this straight.
@efiop efiop added this to the 1.0 milestone Jun 10, 2020
@efiop efiop merged commit 91a7194 into iterative:master Jun 10, 2020
@efiop efiop deleted the file_force branch June 10, 2020 02:05
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Jun 11, 2020

Hi. I see a checkbox was added for this in iterative/dvc.org/issues/1255, thanks. But that's not really a catch all epic for every change from now on 😋

I may be wrong but this doesn't sound like a 1.0-specific change to me, can we open a separate docs issue or PR instead, please?

@efiop
Copy link
Contributor Author

efiop commented Jun 11, 2020

@jorgeorpinel it is used all over the docs and I have no idea what to change there because of all of the 1.0 conflicting PRs hanging that affect all of the docs that I need to change. So I've added it to the epic.

@jorgeorpinel
Copy link
Contributor

Please open an issue and link to the core PR when submitting a PR is not possible. That's totally fine. Done: iterative/dvc.org/issues/1426

@efiop
Copy link
Contributor Author

efiop commented Jun 12, 2020

@jorgeorpinel It was added to the epic get rid of -f in add/run/import(-url) per iterative/dvc#4004 and iterative/dvc#4011, you can see it in the history of changes, but you've deleted it in the past two days.

@jorgeorpinel
Copy link
Contributor

I extracted it into iterative/dvc.org#1426 like I just mentioned. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants