Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: don't implicitly default to pygit2 #86

Open
efiop opened this issue May 31, 2022 · 0 comments
Open

fs: don't implicitly default to pygit2 #86

efiop opened this issue May 31, 2022 · 0 comments

Comments

@efiop
Copy link
Contributor

efiop commented May 31, 2022

get_fs doesn't pass a trie to the fs:

return GitFileSystem(scm=self, rev=rev)

which results in it always defaulting to pygit2

tree_obj = scm.pygit2.get_tree_obj(rev=resolved)

which is against the general scmrepo behavior, where it should go through the backends.

Also GitFileSystem defaulting to pygit2 by itself is also pretty odd by itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant