tests: fs: test all backends #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
changed the title
efiop
commented
May 31, 2022
efiop
commented
May 31, 2022
| @@ -363,6 +363,8 @@ def add_commit( | |||
| validate_git_remote = partialmethod(_backend_func, "validate_git_remote") | |||
| check_ref_format = partialmethod(_backend_func, "check_ref_format") | |||
|
|
|||
| get_tree_obj = partialmethod(_backend_func, "get_tree_obj") | |||
There was a problem hiding this comment.
This is only used in tests now, but in the future we should make get_fs use it and not default to GitFileSystem's default behaviour that uses pygit2.
efiop
commented
May 31, 2022
| @@ -17,35 +17,9 @@ | |||
| ) | |||
| from scmrepo.git import Git | |||
|
|
|||
| # pylint: disable=redefined-outer-name,unused-argument,protected-access | |||
There was a problem hiding this comment.
Need to clean this up at some point
efiop
changed the title
efiop
requested review from
skshetry and
pmrowla
and removed request for
skshetry
|
Note #86 |
|
Guys, I'll merge in the interest of time, but would appreciate if you still take a look. Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.