Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin test deps #345

Merged
merged 1 commit into from
Mar 19, 2024
Merged

unpin test deps #345

merged 1 commit into from
Mar 19, 2024

Conversation

skshetry
Copy link
Member

No description provided.

@skshetry skshetry changed the title unpin deps unpin test deps Mar 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.78%. Comparing base (a00b5ef) to head (a224599).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   78.78%   78.78%           
=======================================
  Files          39       39           
  Lines        5156     5156           
  Branches      931      931           
=======================================
  Hits         4062     4062           
  Misses        930      930           
  Partials      164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skshetry skshetry merged commit 1096899 into main Mar 19, 2024
13 checks passed
@skshetry skshetry deleted the unpin-deps branch March 19, 2024 07:32
@sisp
Copy link
Collaborator

sisp commented Mar 21, 2024

Just out of curiosity: Why do you think unpinning dev/test dependencies is a good idea? I'd argue in favor of pinning – and even locking the entire dependency tree – and letting Dependabot or Renovate help in maintaining the pins/locks. Without pinning/locking, dev environments are non-deterministic, so tracing bugs becomes more difficult across environments. In fact, Renovate's config:best-practices preset includes the :pinDevDependencies preset. IMO, deptry has a great setup w.r.t. dependency management.

WDYT, @skshetry?

@skshetry
Copy link
Member Author

Hi. I like pinning dependencies too, and it's a good idea in general.

Here, it's a tradeoff. With limited resources, and ~20 other libraries to maintain, it's hard for me to keep up with all the updates.

The pytest ecosystem is very mature, and I think it takes less effort to fix any issues that may arise due to a new update of a dependency than keeping up with the spam of updates.

We used to pin all test dependencies before when we had a larger team, but we started unpinning test dependencies in all projects we maintain as the team got smaller.

Also, see iterative/py-template#90.

@sisp
Copy link
Collaborator

sisp commented Mar 21, 2024

Thanks for clarifying and giving some background info. 👍 Have you considered using Renovate with auto-merge? deptry also uses it for some dependency types. If you're unpinning dependencies, there's no downside to automerging as you're not reviewing those changes either way. Regarding update spam (even with auto-merge): You could group updates with Renovate. Just my 2 cents. 😉

@skshetry skshetry self-assigned this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants