Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vega bindings color (smooth template) #3250

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Feb 8, 2023

Related to #3223.

Whilst not perfect I think the color change makes the slider look better overall.

Screenshots

Before

image

image

image

image

After

image

image

image

image

@mattseddon mattseddon added the product PR that affects product label Feb 8, 2023
@mattseddon mattseddon self-assigned this Feb 8, 2023
@mattseddon mattseddon marked this pull request as ready for review February 8, 2023 10:58
@mattseddon mattseddon requested a review from shcheklein February 8, 2023 10:58
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better!

@mattseddon mattseddon enabled auto-merge (squash) February 8, 2023 19:19
@codeclimate
Copy link

codeclimate bot commented Feb 8, 2023

Code Climate has analyzed commit ce1cedc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.9% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 4525e01 into main Feb 8, 2023
@mattseddon mattseddon deleted the improve-vega-bindings-color branch February 8, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants