Give the multiview template extra large sizes for each layer #3759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick prototype for #3757
Screen.Recording.2023-04-25.at.3.02.01.PM.mov
Because we scale down the plot when its layers have 300x300 dimensions, the hypothesis here is that by giving it a very large size, it will also scale down. The problem with this solution, is that there aren't just plots layers inside of this plot. The legends and labels need to be scaled down by a lot to show the big plots.
This is the same thing that's actually happening when the size is 300, but it's less apparent because 300 is a small value and it's easier to fit in the rest (scaling down to 280 will make the legend and labels still scale down only a little as well. Scaling down from 3000 to 500 is a lot to compensate and for VegaLite to find room for other items. We could go for something smaller than 3000, but it's impossible to find the perfect value (big screens vs small screens).
I'll try making this dynamic next.