-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backend logic for bounding box plots #5250
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
d32537c
move classes into its own collapsible row
julieg18 f6fb6c2
keep the same classnames for cells
julieg18 169384b
Store bounding box plot coordinates in single obj
julieg18 91c905e
Merge branch 'bounding-boxes' into stop-passing-bb-coords-as-props
julieg18 9045ab0
first iteration of backend code addition
julieg18 1e76753
Remove frontend bounding box fixture code
julieg18 2c85d58
fix bug in bb fixture
julieg18 ef0b553
fix bug in tests
julieg18 0692a99
Merge branch 'bounding-boxes' into stop-passing-bb-coords-as-props
julieg18 8cace73
fix merge conflicts
julieg18 ba4bdd0
fix typo
julieg18 b1abf5d
Merge branch 'stop-passing-bb-coords-as-props' into add-bb-backend-logic
julieg18 dd431e1
add toggle comparison class logic and additional tests
julieg18 d240272
Merge branch 'bounding-boxes' into add-bb-backend-logic
julieg18 4da57cb
final lookover
julieg18 d09e5f0
Update coordinate system
julieg18 646306a
apply review comments
julieg18 86767f6
update schema
julieg18 7fce713
Merge branch 'bounding-boxes' into add-bb-backend-logic
julieg18 0176f1a
move colors and use var when collecting plot class details
julieg18 ff95253
rely on collected comparison plots when grabbing selected class boxes
julieg18 c6e59f0
add additional optimisation
julieg18 06b6f5b
fix typo
julieg18 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
const colorsList = [ | ||
'#945dd6', | ||
'#13adc7', | ||
'#f46837', | ||
'#48bb78', | ||
'#4299e1', | ||
'#ed8936', | ||
'#f56565' | ||
] as const | ||
|
||
export type Color = (typeof colorsList)[number] | ||
|
||
export const copyOriginalColors = (): Color[] => [...colorsList] | ||
|
||
const boundingBoxColorsList = [ | ||
sroy3 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
'#ff3838', | ||
'#ff9d97', | ||
'#ff701f', | ||
'#ffb21d', | ||
'#cfd231', | ||
'#48f90a', | ||
'#92cc17', | ||
'#3ddb86', | ||
'#1a9334', | ||
'#00d4bb', | ||
'#2c99a8', | ||
'#00c2ff', | ||
'#344593', | ||
'#6473ff', | ||
'#0018ec', | ||
'#8438ff', | ||
'#520085', | ||
'#cb38ff', | ||
'#ff95c8', | ||
'#ff37c7' | ||
] as const | ||
|
||
export type BoundingBoxColor = (typeof boundingBoxColorsList)[number] | ||
|
||
export const getBoundingBoxColor = (ind: number): BoundingBoxColor => | ||
boundingBoxColorsList[ind % boundingBoxColorsList.length] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I based the output off of iterative/dvclive#766 (comment) description, but this will most likely change and we will need to adjust accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to
top
,bottom
,right
,left
based off the top-left corner after a discussion with Alex (see his comment):