Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable window options #5

Closed
wants to merge 5 commits into from
Closed

Conversation

muemmel
Copy link

@muemmel muemmel commented Aug 31, 2022

Somewhat addressing issue #3

Window options, as well as Window highlights, can now be customized.
Run now passes it's opts to Open.

This allows a workaround for the window opening off screen in certain Neovide builds by setting winopts.col to around the difference between the UI width and winopts.width.

I personally use

winopts.col = vim.o.co - width - 5

The math floor was a remnant from division. :D

- neoterm.setup() now accepts opts.winopts and opts.winhighlight
- winopts as per nvim_open_win() config table or function that returns a config table
- winhighlight as per winhl/winhighlight or function that returns a string
- mode set to custom if winopts configured
@itmecho
Copy link
Owner

itmecho commented Sep 26, 2024

Hi @muemmel, sorry this fell through the cracks! Is this still relevant to you?

I've just merged a different PR which adds a width option, would that solve your problem?

@dpi0
Copy link
Contributor

dpi0 commented Sep 27, 2024

@muemmel @itmecho I suppose after the merge of #17. This can be closed now.

@itmecho
Copy link
Owner

itmecho commented Sep 27, 2024

@muemmel Thank you for doing this, I'm sorry I missed it!

I'm going to close this as I believe it's been fixed by another PR (#17). If you're still getting this issue, please open a new issue =]

@itmecho itmecho closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants