Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daemon): add service with ClamAV sidecars for Debian #106

Conversation

ivangabriele
Copy link
Owner

@ivangabriele ivangabriele commented Nov 23, 2023

Description

Creating basic service daemon for Linux, macOS & Windows.

Checklist

  • I updated the documentation accordingly. Or I don't need to.
  • I updated the tests accordingly. Or I don't need to.

@ivangabriele ivangabriele changed the title feat(daemon): add service with ClamAV sidecars [WIP] feat(daemon): add service with ClamAV sidecars Nov 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.94%. Comparing base (6ed14ec) to head (7f8bb52).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   36.94%   36.94%           
=======================================
  Files          23       23           
  Lines         720      720           
  Branches        2        2           
=======================================
  Hits          266      266           
  Misses        454      454           
Flag Coverage Δ
core 37.35% <ø> (ø)
webview 25.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivangabriele ivangabriele force-pushed the ivan/feat-daemon-add-clamav-desktop-daemon-with-clamav-sidecars branch 2 times, most recently from e56f5f7 to 980353b Compare November 23, 2023 09:04
@ivangabriele ivangabriele added feature:approved Approved new feature or feature enhancement. os:debian os:windows os:macos labels Jun 8, 2024
@ivangabriele ivangabriele force-pushed the ivan/feat-daemon-add-clamav-desktop-daemon-with-clamav-sidecars branch from 980353b to bd39e3d Compare August 31, 2024 09:13
@ivangabriele ivangabriele added this to the v0.4 milestone Aug 31, 2024
@ivangabriele ivangabriele force-pushed the ivan/feat-daemon-add-clamav-desktop-daemon-with-clamav-sidecars branch 13 times, most recently from 22b9c60 to c169a45 Compare September 2, 2024 13:01
@ivangabriele ivangabriele changed the title feat(daemon): add service with ClamAV sidecars feat(daemon): add service with ClamAV sidecars for Debian Sep 4, 2024
@ivangabriele ivangabriele force-pushed the ivan/feat-daemon-add-clamav-desktop-daemon-with-clamav-sidecars branch from 9594ab7 to 438bbab Compare September 8, 2024 08:28
@ivangabriele ivangabriele force-pushed the ivan/feat-daemon-add-clamav-desktop-daemon-with-clamav-sidecars branch from 35554e4 to 7f8bb52 Compare September 8, 2024 10:11
@ivangabriele ivangabriele marked this pull request as ready for review September 8, 2024 10:23
Copy link

coderabbitai bot commented Sep 8, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces significant updates across multiple files, primarily focusing on enhancing the build and deployment process for the ClamAV Desktop Daemon. Key changes include updates to Docker images for various workflows, the addition of ARM64 support, modifications to installation scripts for Debian systems, and improvements in the handling of client-server communications through WebSocket integration. Additionally, new scripts are introduced for managing service installations and uninstallation, along with enhancements to the documentation for developers.

Changes

File(s) Change Summary
.github/workflows/*.yml Updated Docker images from debian-bullseye-18 to debian-bookworm-18 for various jobs.
.gitignore Added entries to ignore Rust build artifacts and Tauri-related files.
CONTRIBUTING.md Enhanced documentation with new sections, updated commands, and added warnings for known issues.
assets/msi/postinstall.nsi, assets/pkg/postinstall.sh Introduced scripts for managing installation and uninstallation of the ClamAV daemon on Windows and macOS.
daemon/* Added new functionalities for handling client messages, including WebSocket communication and state management.
scripts/build/*.js, scripts/dev/*.sh Introduced and modified scripts for building, installing, and cleaning up the ClamAV daemon on Debian systems.
src-tauri/embeds/deb/*.service, src-tauri/embeds/deb/{postinst, prerm} Added service configuration and management scripts for the ClamAV daemon.
src-tauri/src/dashboard/{commands.rs, mod.rs, types.rs} Introduced a new module for dashboard commands and types, enhancing client-daemon communication.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant WebSocketServer
    participant Daemon

    Client->>WebSocketServer: Send "Ping" message
    WebSocketServer->>Daemon: Forward "Ping" message
    Daemon->>WebSocketServer: Respond with "Pong"
    WebSocketServer->>Client: Send "Pong" response
Loading

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ivangabriele ivangabriele merged commit 8d52924 into main Sep 8, 2024
18 checks passed
@ivangabriele ivangabriele deleted the ivan/feat-daemon-add-clamav-desktop-daemon-with-clamav-sidecars branch September 8, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:approved Approved new feature or feature enhancement. os:debian
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants