Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webview): finalize v0.4.0 UI #155

Merged
merged 72 commits into from
Sep 15, 2024
Merged

feat(webview): finalize v0.4.0 UI #155

merged 72 commits into from
Sep 15, 2024

Conversation

ivangabriele
Copy link
Owner

@ivangabriele ivangabriele commented Sep 13, 2024

Description

Create Storybook and finalize all UI components for next v0.4.0.

Checklist

  • I updated the documentation accordingly. Or I don't need to.
  • I updated the tests accordingly. Or I don't need to.

@ivangabriele ivangabriele added the feature:approved Approved new feature or feature enhancement. label Sep 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 19.04762% with 51 lines in your changes missing coverage. Please review.

Project coverage is 35.50%. Comparing base (eacb93f) to head (e439cc6).

Files with missing lines Patch % Lines
src/components/FileExplorer/utils.ts 0.00% 45 Missing ⚠️
src/stories/screens/utils.ts 0.00% 2 Missing ⚠️
src/utils/noop.ts 0.00% 2 Missing ⚠️
src/utils/waitFor.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   36.94%   35.50%   -1.44%     
==========================================
  Files          23       29       +6     
  Lines         720      783      +63     
  Branches        2       15      +13     
==========================================
+ Hits          266      278      +12     
- Misses        454      505      +51     
Flag Coverage Δ
core 37.35% <ø> (ø)
webview 20.68% <19.04%> (-4.32%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivangabriele ivangabriele added this to the v0.4 milestone Sep 15, 2024
@ivangabriele ivangabriele marked this pull request as ready for review September 15, 2024 00:55
Copy link

coderabbitai bot commented Sep 15, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes encompass the addition of new components, utilities, and styles, along with significant refactoring of existing components and their associated types. Key updates include the introduction of a centralized argument management system in Storybook, enhancements to file explorer functionalities, and the restructuring of the application's layout and navigation. The codebase has been organized for better maintainability with the introduction of enums, interfaces, and utility functions, while global styles have been transitioned from styled-components to a separate CSS file.

Changes

File(s) Change Summary
.gitignore Added *storybook.log to ignore Storybook log files.
.storybook/argsStore/*.ts Introduced a centralized ArgsStore class for managing argument states, added constants for component keys, and defined types/interfaces for argument handling.
.storybook/main.ts Configured Storybook for a React application using Vite, including addons and static directory settings.
.storybook/preview.css Established foundational styles for the Storybook environment.
.storybook/preview.tsx Configured decorators and parameters for Storybook, enhancing story presentation.
biome.jsonc Added overrides for TypeScript linter rules specific to .storybook and src/stories directories.
configs/jest.config.js Enhanced Jest configuration with TypeScript annotations and added testPathIgnorePatterns.
src/App.tsx Refactored to use a Screen enum for managing the current screen and simplified the layout management.
src/Layout.tsx Introduced a new Layout component for structuring the UI.
src/components/Card/*.tsx Added a new Card component with customizable actions and loading states.
src/components/FileExplorer/*.tsx Implemented a new file explorer with enhanced node management, check states, and utility functions.
src/components/LogList/*.tsx Introduced a logging system with components for displaying log entries and processing logs into a structured format.
src/constants.ts Added new constants and enums for improved state management, replacing the Page enum with Screen.
src/core/*.ts Introduced new types and namespaces to better structure the core application framework.
src/elements/*.tsx Added new spinner components for loading indicators with customizable properties.
src/global.css Established global styles for the application, transitioning from styled-components to a CSS file.
src/hooks/useDebouncedMemo.ts Introduced a custom hook for memoizing values with debouncing.
src/index.tsx Removed the custom global style component and replaced it with an imported CSS file.
src/layouts/*.tsx Refactored layout components for better structure and usability, including the removal of the Screen component.
src/screens/*.tsx Removed the Cloud screen component and introduced a new DashboardScreenComponent.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant ArgsStore
    participant FileExplorer

    User->>App: Interacts with UI
    App->>ArgsStore: Get/Update Arguments
    ArgsStore-->>App: Return Arguments
    App->>FileExplorer: Render File Structure
    FileExplorer-->>App: Display Nodes
    App-->>User: Update UI
Loading

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ivangabriele ivangabriele merged commit 6bb3986 into main Sep 15, 2024
18 checks passed
@ivangabriele ivangabriele deleted the ivan/style-ui-create branch September 15, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:approved Approved new feature or feature enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants