-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pretext to start a discussion ;) #15
base: master
Are you sure you want to change the base?
Conversation
…ter decorated function is incorrect
Hi @Houston4444, yes all these points are worth discussing, but I'm currently a bit busy with other things. But I'll write a longer answer soon (next week). |
@SpotlightKid , we both seem to have forgotten this thread. As I am reworking on a 6 months old RaySession branch, I wonder if I keep the pyjacklib submodule linked to my fork, or if work could be done in this one. |
@Houston4444 To be honest, I haven't done any serious FLOSS development in the past months (or almost a year). I'm just lacking motivation at the moment, and I am more interested in making music currently. So I suggest you either maintain your own branch or talk to @falkTX to give you access to this repo. Concerning your changes, I think most things are good, but I would like this lib to maintain a strong separation between pure wrapping of the C |
Ok, I've done some code split and enums here : https://github.com/Houston4444/pyjacklib/tree/orga/new_split I'll use my own version now, but I am still open to discussion of course about changes in jackaudio version. |
As the title say, I don't expect this PR to be merged as it is. I made some changes in many parts for many reasons, I could propose things one by one of course.
I am motivated to make some work on this lib, I use it myself 3 times in my softs (Patchance + RaySession x 2).
I would be happy to have your opinion about the following points:
I was wondering why there were callbacks CFUNCTYPE saved as global (_thread_init_callback, _shutdown_callback ... example line 699/700) in the API functions. I discovered that it was just a way to prevent python cleaner to remove these objects. In addition to the fact that I find it quite dirty, I see the impossibility to get 2 jack clients with same callback working correctly (the 2nd callback will erase the 1st, not tested but I am pretty sure). That's why I simply add theses objects to a list (_used_callbacks).