Jcn-488 Adaptar metodo multiUpdate para que acepte multiples operadores y operaciones con pipeline aggregation #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alejandro-Gonzalez
requested changes
Jun 19, 2024
lib/mongodb.js
Outdated
|
|
||
| if(!data || !Object.keys(data).length) | ||
| throw new MongoDBError('Every operation must have data to update', MongoDBError.codes.INVALID_ITEM); | ||
|
|
||
| const { id, dateModified, dateCreated, ...dataToUpdate } = data; // to avoid overriding | ||
| const operationData = Array.isArray(data) ? [...data] : [data]; |
There was a problem hiding this comment.
@calandrajose en multiUpdate y update hace casi lo mismo podemos hacer un método que haga esto de formatear la data y que valide data y filtro si es de multiUpdate con segun el un parametro que le pases y que el metodo te devuelvan el updatedData y updateMethod
Alejandro-Gonzalez
approved these changes
Jun 25, 2024
gastonpereyra
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
historia
subtarea
Descripcion del requerimiento:
Se requiere modificar el metodo multiUpdate para que acepte pipelines y multiples operadores (hoy automaticamente asigna lo recibido a un $set) dentro de los valores a actualizar en cada operacion.
Como probar
Dejo pruebas en playground
Funcionamiento con pipelines
Funcionamiento con updates normales (funcionamiento vigente y que debe continuar)
Changelog: