[JCN-497-support-array-type-attributes] - add support to array attrib… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link de la tarea
Epica: https://janiscommerce.atlassian.net/browse/JCN-496
Subtarea: https://janiscommerce.atlassian.net/browse/JCN-497
Descripción del requerimiento
Actualmente el paquete asume que todos los atributos cargados al mensaje son de tipo String. Esto hace que en escenarios en los que, por ejemplo se necesite que el mensaje sea filtrado por multiples recursos con criterios diferentes, la filter policy no pueda procesar correctamente esos atributos ya que a pesar de tener un value de tipo Array, su data type se interpreta como string, lo cual termina rompiendo la condicion de igualdad que busca el filtro.
Ej: Si se publica un mensaje comunicando la actualizacion de un producto que se vende en 3 plataformas, el unico camino que tenemos hoy es creando 3 mensajes, uno por plataforma. Si el paquete formateara correctamente los atributos
Para esto se debe modificar el paquete https://www.npmjs.com/package/@janiscommerce/sns para que admita atributos de tipo array.