Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update play-bot.js #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update play-bot.js #64

wants to merge 1 commit into from

Conversation

M4CC
Copy link

@M4CC M4CC commented Mar 22, 2024

Updated terraforming-mars related paths.

Updated terraforming-mars related paths.
@jankeromnes
Copy link
Owner

Many thanks for updating terraforming-mars-bot!

I gave this Pull Request a quick test, but I noticed that, if use your fix and also update the terraformin-mars sub-module, then node start-game no longer works:

Error: Couldn't PUT http://localhost:8080/game - Response status: 500

And when looking at the terraforming-mars game server logs, I see:

internal server error:  /game TypeError: Cannot read properties of undefined (reading 'includes')
    at /workspace/terraforming-mars-bot/terraforming-mars/build/src/server/GameCards.js:105:49

I believe this is because the gameSettings we provide are now outdated (e.g. they're at least missing a bannedCards empty array):

const gameSettings = {
"players": [],
"corporateEra": true,
"prelude": false,
"draftVariant": false,
"showOtherPlayersVP": false,
"venusNext": false,
"colonies": false,
"turmoil": false,
"customCorporationsList": [],
"customColoniesList": [],
"cardsBlackList": [],
"board": "tharsis",
"seed": 0.28529731680252757,
"solarPhaseOption": false,
"promoCardsOption": false,
"communityCardsOption": false,
"aresExtension": false,
"undoOption": false,
"fastModeOption": false,
"removeNegativeGlobalEventsOption": false,
"includeVenusMA": true,
"startingCorporations": 2,
"soloTR": false,
"initialDraft": false,
"randomMA": "No randomization",
"shuffleMapOption": false,
"beginnerOption": false,
"randomFirstPlayer": true,
"requiresVenusTrackCompletion": false
};

I'll look into updating the new game settings in the start-game script.

@M4CC
Copy link
Author

M4CC commented Mar 25, 2024

Thank you for all your hard work on this project @jankeromnes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants