Allow XResponses to keep original headers provided to base response #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luzfcb
reviewed
Jul 31, 2024
| """Return a HttpResponse with headers for Apache X-Sendfile.""" | ||
| super().__init__(content_type=content_type) | ||
| # content-type must be porvided only as keyword argument to response |
There was a problem hiding this comment.
There is a small spelling error in the word and the same error is made in other files
Suggested change
| # content-type must be porvided only as keyword argument to response | |
| # content-type must be provided only as keyword argument to response |
Natim
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the middleware re-initialize a new response, this cause the loss of any previously set header.
This aims to provide such possibility when using the current codebase.
See #205