Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/wellknown openid configuration no trailing slash #1364

Conversation

dopry
Copy link
Contributor

@dopry dopry commented Nov 10, 2023

Fixes #1363

Description of the Change

Update endpoint to handle both with and without trailing slash, add comment noting the tailing slash is deprecated and should be removed in the future.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #1364 (6bfff1d) into master (862cb7a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1364   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files          32       32           
  Lines        2120     2120           
=======================================
  Hits         2068     2068           
  Misses         52       52           
Files Coverage Δ
oauth2_provider/settings.py 100.00% <100.00%> (ø)
oauth2_provider/urls.py 100.00% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@dopry dopry force-pushed the fix/wellknown-openid-configuration-no-trailing-slash branch 6 times, most recently from bd3eb89 to 7649c0c Compare November 11, 2023 17:09
@dopry dopry requested a review from n2ygk November 11, 2023 17:10
@dopry dopry force-pushed the fix/wellknown-openid-configuration-no-trailing-slash branch 3 times, most recently from 518669d to c9cab34 Compare November 11, 2023 20:14
@dopry dopry requested review from tonial and andyzickler November 11, 2023 20:27
@dopry dopry force-pushed the fix/wellknown-openid-configuration-no-trailing-slash branch from c9cab34 to 6bfff1d Compare November 11, 2023 21:00
Copy link
Contributor

@tonial tonial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dopry dopry merged commit e038f42 into jazzband:master Nov 13, 2023
25 checks passed
@dopry dopry deleted the fix/wellknown-openid-configuration-no-trailing-slash branch November 13, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/.well-known/openid-configuration is redirected to /.well-known/openid-configuration/
2 participants