Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pytest for testing & modernize assertions #562

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

akx
Copy link
Contributor

@akx akx commented Dec 12, 2023

This switches to pytest + pytest-cov + pytest-django for testing, and uses https://github.com/akx/codemod-unittest-to-pytest-asserts to codemod all self.assertSomethingSomething style assertions to plain assertions, which Py.test can rewrite for a better DX.

@akx akx force-pushed the improve-testing branch 2 times, most recently from eecfaf6 to e99f7e9 Compare December 12, 2023 11:27
@akx akx requested a review from j-antunes December 14, 2023 10:54
@j-antunes
Copy link
Contributor

Thanks for your awesome work on this! I'll leave it up this PR up for a little longer just in case someone wants to also review it. Later in the day let's start merging your open PRs

@akx akx force-pushed the improve-testing branch 2 times, most recently from ab9d61b to 4ad5640 Compare December 18, 2023 12:47
@j-antunes j-antunes merged commit 4240931 into jazzband:master Dec 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants