Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tzdata #266

Merged
merged 1 commit into from
Dec 8, 2023
Merged

feat: add tzdata #266

merged 1 commit into from
Dec 8, 2023

Conversation

caveman99
Copy link
Contributor

so the container can be setup to use different timezones via the TZ ENV Variable

@jbergstroem
Copy link
Owner

Thanks for the contribution! Do you think you're able to make a test for this? Check this file for inspiration: https://github.com/jbergstroem/mariadb-alpine/blob/main/test/config.sh

You'd essentially set TZ and then check that its properly set in SHOW SESSION VARIABLES LIKE 'system_time_zone'

@caveman99
Copy link
Contributor Author

Sure thing, I'll commit later tonight.

@caveman99
Copy link
Contributor Author

@jbergstroem sorry for taking so long, the included test should work, at least it does on my fork :-)

@jbergstroem
Copy link
Owner

@jbergstroem sorry for taking so long, the included test should work, at least it does on my fork :-)

Great! will take a look later today.

@jbergstroem jbergstroem changed the title add tzdata feat: add tzdata Dec 8, 2023
Pass timezone info to the runtime container to make MariaDB pick it up:

```bash
$ docker run -it -e "TZ=CET" jbergstroem/mariadb-alpine
```

PR: #266
@jbergstroem jbergstroem merged commit 224d159 into jbergstroem:main Dec 8, 2023
7 checks passed
@jbergstroem
Copy link
Owner

Thanks a lot for your contribution!

@caveman99
Copy link
Contributor Author

Thanks for including the patch... i had a compose stack running where the app was complaining that the DB was one hour off (CET vs. UTC). It was working, but the permanent error in the status bar was annoying and irritating for customers... :-)

@jbergstroem
Copy link
Owner

Thanks for including the patch... i had a compose stack running where the app was complaining that the DB was one hour off (CET vs. UTC). It was working, but the permanent error in the status bar was annoying and irritating for customers... :-)

I will update the latest image shortly.

@jbergstroem
Copy link
Owner

@jbergstroem
Copy link
Owner

10.11.5 and latest now contains the feature (bug? 😄) https://hub.docker.com/r/jbergstroem/mariadb-alpine/tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants