Better DateTime parsing, options to promote NULL int columns to float #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dealing with data types where no 1:1 mapping to np.type is possible, the code needs to have more possibilites to modify column properties. In particular, this commit addresses - DateTime columns (exported as ISO 8601 string, column index put into parse_csv's parse_dates argument) - Integer & Long Integer columns which may be NULL and promotion rules into np.float_ (either all int columns or the ones not markes "NOT NULL") - There were no tests at all. This commit introduces a few basic tests for column parsing.
MichaelMMeskhi
approved these changes
Aug 20, 2020
DeflateAwning
approved these changes
May 16, 2023
|
I have reviewed these changes, and approve of them being integrated to the upstream repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with data types where no 1:1 mapping to np.type is possible, the code needs to have more possibilites to modify column properties.
In particular, this PR addresses