-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the algorithm #4
Draft
jeltsch
wants to merge
32
commits into
master
Choose a base branch
from
enhancement/algorithm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The key to have a short, largely automatic proof is to explicitly specify that the witness for the existential statement is `Map.empty`.
This enables us to easily use the constraints of the `element_labeling` subtype in future proofs.
The new definition consistently uses `parent`. For this to be possible, it uses small steps also in the first two clauses.
Previously, the conditions in the definition of `lowest_common_ancestor` were specified using Pure implications.
We do not want to make `nat × nat` an instance of `semilattice_sup`, since there are lattice structures for this type that are more standard than our structure.
The previous version did not outrule cycles as such but only outruled that all vertices have cycles of a certain common size.
For a function with an associated termination proof, no `domintros` seem to be generated anyhow. The generation of `domintros` would also be superfluous, as the termination proof has access to the local `termination` rule and generated facts do not refer to `domintros`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ultimately resolve #3.