Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin usage strings #8768

Closed
wants to merge 1 commit into from
Closed

fix: plugin usage strings #8768

wants to merge 1 commit into from

Conversation

msvticket
Copy link
Member

Since cobra only use the usage string up until the first space as command name in help I change to use non-breakable space in the env variables some plugins (for example jx-gitops) use to set use.

https://github.com/spf13/cobra/blob/v1.8.1/command.go#L1503

Since cobra only use the usage string up until the first space as command name in help I change to use non-breakable space in the env variables some plugins (for example jx-gitops) use to set use.

https://github.com/spf13/cobra/blob/v1.8.1/command.go#L1503

Signed-off-by: Mårten Svantesson <[email protected]>
@msvticket
Copy link
Member Author

/cc tomhobson JordanGoasdoue Skisocks mentlak0

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign msvticket
You can assign the PR to them by writing /assign @msvticket in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msvticket
Copy link
Member Author

/retest

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.60%. Comparing base (7b0e811) to head (f891f23).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/root.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8768   +/-   ##
=======================================
  Coverage   31.60%   31.60%           
=======================================
  Files          11       11           
  Lines        1370     1370           
=======================================
  Hits          433      433           
  Misses        893      893           
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msvticket
Copy link
Member Author

/retest

1 similar comment
@msvticket
Copy link
Member Author

/retest

@jenkins-x-bot
Copy link
Contributor

@msvticket: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
lint f891f23 link /test lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@msvticket
Copy link
Member Author

A confusing drawback with this fix is that if you copy the command from the help and paste in a shell it won't work, since nbsp isn't interpreted as space by the shell either.

Instead the fix is to use a cobra annotation to set the name. See jenkins-x-plugins/jx-gitops#1001

/close

@jenkins-x-bot
Copy link
Contributor

@msvticket: Closed this PR.

In response to this:

A confusing drawback with this fix is that if you copy the command from the help and paste in a shell it won't work, since nbsp isn't interpreted as space by the shell either.

Instead the fix is to use a cobra annotation to set the name. See jenkins-x-plugins/jx-gitops#1001

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants