-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: plugin usage strings #8768
Conversation
Since cobra only use the usage string up until the first space as command name in help I change to use non-breakable space in the env variables some plugins (for example jx-gitops) use to set use. https://github.com/spf13/cobra/blob/v1.8.1/command.go#L1503 Signed-off-by: Mårten Svantesson <[email protected]>
/cc tomhobson JordanGoasdoue Skisocks mentlak0 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8768 +/- ##
=======================================
Coverage 31.60% 31.60%
=======================================
Files 11 11
Lines 1370 1370
=======================================
Hits 433 433
Misses 893 893
Partials 44 44 ☔ View full report in Codecov by Sentry. |
/retest |
1 similar comment
/retest |
@msvticket: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
A confusing drawback with this fix is that if you copy the command from the help and paste in a shell it won't work, since nbsp isn't interpreted as space by the shell either. Instead the fix is to use a cobra annotation to set the name. See jenkins-x-plugins/jx-gitops#1001 /close |
@msvticket: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
Since cobra only use the usage string up until the first space as command name in help I change to use non-breakable space in the env variables some plugins (for example jx-gitops) use to set use.
https://github.com/spf13/cobra/blob/v1.8.1/command.go#L1503