Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Server eventKey for Server Action #354

Conversation

RMadsenG
Copy link
Contributor

Fixes #322

The if statement in getLatestCommit compares the eventKey to fulfilled instead of merged. This is causing merge builds to checkout the latest commit of the source branch instead of the merge commit.

Updating the constant to the BB Server constant.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@RMadsenG
Copy link
Contributor Author

Hello,
Reading the documentation here: https://github.com/actions/labeler, it looks the the Pull Request Labeler is failing bc I raised this pull request from my own fork. Is there any way around this?
Thank You

@RMadsenG
Copy link
Contributor Author

@julioc-p @cdelmonte-zg Can you please review this when you have time.
thanks

@cdelmonte-zg
Copy link
Contributor

Thank you @RMadsenG , it will be in the next bugfix release

@cdelmonte-zg cdelmonte-zg merged commit 0a227af into jenkinsci:master Dec 28, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not checkout merge commit in Jenkins Pipeline
2 participants