Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid junit-dep from system-rules #2601

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jglick
Copy link
Member

@jglick jglick commented Nov 25, 2024

Seems to prevent an error in a proprietary plugin when trying to validate using Maven 4.0.0-rc-1:

[ERROR] Failed to execute goal on project xxx: Could not collect dependencies for project xxx:hpi:999999-SNAPSHOT
[ERROR] org.eclipse.aether.resolution.VersionRangeResolutionException: No versions available for junit:junit-dep:jar:[4.9,) within specified range
[ERROR] 	Caused by: No versions available for junit:junit-dep:jar:[4.9,) within specified range
[ERROR] : Failed to collect dependencies at io.jenkins.configuration-as-code:test-harness:jar:1897.v79281e066ea_7 -> com.github.stefanbirkner:system-rules:jar:1.19.0 -> junit:junit-dep:jar:[4.9,)

Tried without success to reproduce in an OSS POM; the trigger condition seems to relate to use of a proprietary <repository> with snapshots enabled, which I guess causes the resolver to attempt to search for a valid junit-dep version? Anyway we definitely do not want this transitive dep, and removing it fixes this error. (I still have other problems with some repos, even this one, using Maven 4.)

@jglick jglick requested a review from a team as a code owner November 25, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants