Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-75011] Use Apache Mina as ssh transport layer, remove trilead #1022

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jmdesprez
Copy link

PR for JENKINS-75011

Mainly, the changes consist of:

  • Create a SshClient where a connection is needed
  • Replace Connection by ClientSession
  • Replace SCPClient by CloseableScpClient
  • use try-with-resource for Closeable resources
  • Add ProxyCONNECTListener for the http proxy CONNECT
  • Add PEMParser because Mina requires a KeyPair instead of a char[]

Testing done

I create this in draft mode because I'm still doing manual tests.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

public final String targetHost;
public final int targetPort;
public final String proxyUser;
public final String proxyPass;

Check warning

Code scanning / Jenkins Security Scan

Jenkins: Plaintext password storage Warning

Field should be reviewed whether it stores a password and is serialized to disk: proxyPass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant