Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EmbeddableBadgeConfig tests #179

Merged
merged 5 commits into from
Mar 16, 2023
Merged

Add EmbeddableBadgeConfig tests #179

merged 5 commits into from
Mar 16, 2023

Conversation

wliao008
Copy link

added some simple tests for EmbeddableBadgeConfig. ref #114

Wei Liao and others added 5 commits March 16, 2023 11:28
added tests for EmbeddableBadgeConfig
2ef22ee
@MarkEWaite
Format the test
5c94e5c
@MarkEWaite
Add code formatting to contributing guide
9b70646
@MarkEWaite
Prefer more verbose descriptor IDs
d606693 
Easier to diagnose test failures when the descriptor ID is distinct in
each test.
@MarkEWaite
Use is() instead of IsNull for consistency
044ab13 
The rest of the test uses `is()`. Other tests in the plugin also use `is()`
MarkEWaite
MarkEWaite approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

I pushed some changes to the tests and the CONTRIBUTING file based on the tests that you created.

@MarkEWaite MarkEWaite changed the title 114: added tests for EmbeddableBadgeConfig Add tests for EmbeddableBadgeConfig Mar 16, 2023
@MarkEWaite MarkEWaite changed the title Add tests for EmbeddableBadgeConfig Add EmbeddableBadgeConfig tests Mar 16, 2023
@MarkEWaite MarkEWaite enabled auto-merge (rebase) March 16, 2023 15:49
@MarkEWaite MarkEWaite merged commit 4dab4f3 into jenkinsci:master Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wliao008 @MarkEWaite