Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-70464] Test EmbeddableBadgeConfigsAction #250

Merged
merged 6 commits into from
Oct 9, 2023
Merged

[JENKINS-70464] Test EmbeddableBadgeConfigsAction #250

merged 6 commits into from
Oct 9, 2023

Conversation

abhishekmaity
Copy link
Contributor

@abhishekmaity abhishekmaity commented Oct 8, 2023 •
edited
Loading

In response to #114,

Testing done

  • added EmbeddableBadgeConfigsActionTest.java
  • Test coverage shown below

Screenshot 2023-10-09 012452

Submitter checklist
Preview Give feedback

@abhishekmaity abhishekmaity requested a review from a team as a code owner October 8, 2023 19:59
@abhishekmaity abhishekmaity changed the title [JENKINS-70464] Test 'EmbeddableBadgeConfigsActionTest' [JENKINS-70464] Test EmbeddableBadgeConfigsAction Oct 8, 2023
@MarkEWaite MarkEWaite added the tests Automated test addition or improvement label Oct 8, 2023
MarkEWaite
MarkEWaite requested changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unused mock objects and the two tests that are not testing anything in the target class.

src/test/java/org/jenkinsci/plugins/badge/actions/EmbeddableBadgeConfigsActionTest.java Outdated Show resolved Hide resolved
src/test/java/org/jenkinsci/plugins/badge/actions/EmbeddableBadgeConfigsActionTest.java Outdated Show resolved Hide resolved
src/test/java/org/jenkinsci/plugins/badge/actions/EmbeddableBadgeConfigsActionTest.java Outdated Show resolved Hide resolved
src/test/java/org/jenkinsci/plugins/badge/actions/EmbeddableBadgeConfigsActionTest.java Outdated Show resolved Hide resolved
@abhishekmaity
Copy link
Contributor Author

@MarkEWaite changes applied as per suggestion

MarkEWaite
MarkEWaite approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite merged commit 01b7dfc into jenkinsci:master Oct 9, 2023
15 checks passed
@abhishekmaity abhishekmaity deleted the test-coverage-2 branch October 9, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
tests Automated test addition or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhishekmaity @MarkEWaite