Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jenkins-controller-svc.yaml #1170

Closed
wants to merge 4 commits into from
Closed

Conversation

dimarvim
Copy link

@dimarvim dimarvim commented Aug 13, 2024

What does this PR do?

An explicit ‘agent-listener’ section has been added to the service, aligning with the existing section in the StatefulSet manifest.

  • Fixes #

jenkins-controller-svc.yaml

Submitter checklist

Preview Give feedback

Special notes for your reviewer

An explicit ‘agent-listener’ section has been added to the service, aligning with the existing section in the StatefulSet manifest.
@dimarvim dimarvim requested a review from a team as a code owner August 13, 2024 07:15
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add documentation (see values.yaml for how its done), changelog, bump the chart version

@dimarvim dimarvim requested a review from timja August 13, 2024 08:21
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably misunderstanding but this appears to already exist at

- port: {{ .Values.controller.agentListenerPort }}

it is confusing that its on another service but I don't think we need to change that

@dimarvim dimarvim closed this Aug 13, 2024
@dimarvim
Copy link
Author

The agent-listener section is unnecessary, as the agent-listener has a dedicated service manifest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants